Bug 2209328 - Fix potential crash in logind
Summary: Fix potential crash in logind
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: systemd
Version: 8.2
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: 8.0
Assignee: David Tardon
QA Contact: Frantisek Sumsal
URL:
Whiteboard:
Depends On:
Blocks: 2105959 2170959
TreeView+ depends on / blocked
 
Reported: 2023-05-23 13:43 UTC by Ray Strode [halfline]
Modified: 2023-08-16 09:30 UTC (History)
16 users (show)

Fixed In Version: systemd-239-77.el8
Doc Type: Enhancement
Doc Text:
Clone Of: 2105959
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github redhat-plumbers systemd-rhel8 pull 395 0 None open logind: simplify code 2023-06-01 07:04:42 UTC
Github systemd systemd pull 23809 0 None Merged logind: simplify code 2023-06-01 06:57:02 UTC
Red Hat Issue Tracker RHELPLAN-157943 0 None None None 2023-05-23 13:46:50 UTC

Description Ray Strode [halfline] 2023-05-23 13:43:35 UTC
+++ This bug was initially created as a clone of Bug #2105959 +++

--- Additional comment from Ray Strode [halfline] on 2023-02-17 13:55:35 EST ---

This is an untested starting point, that will probably need more work before it can go upstream.

It's also definitely insufficient for downstream, since it uses MetaContext, which I don't think existed in RHEL 8.

I'm just posting this here for my own notes when I revisit for 8.9

--- Additional comment from Ray Strode [halfline] on 2023-05-22 09:37:16 EDT ---

(hoping to get to this today)

--- Additional comment from Ray Strode [halfline] on 2023-05-23 09:41:54 EDT ---

So I ran into an issue with this. logind is crashing. It needs this fix:

https://github.com/systemd/systemd/commit/e5c09aad375551b9db499703ab7eb123d408ba16

(because session_set_display calls streq on a null string otherwise)

Comment 1 Ray Strode [halfline] 2023-05-24 15:10:42 UTC
fwiw, we've decided not to use this feature.  It would still be good to fix the crasher, of course, but the feature is not needed anymore.

Comment 2 Plumber Bot 2023-07-13 11:26:29 UTC
fix merged to github main branch -> https://github.com/redhat-plumbers/systemd-rhel8/pull/395


Note You need to log in before you can comment on or make changes to this bug.