[ Withdrawing myself as reviewer of this package due to BuildRoot disagreements.
See bug #220888 comment 15 for information. ]

Not a very official review because I am not in fedorabugs group yet (just
requested that).

MUST items
- rpmlint on source returns only 
E: po4a unknown-key GPG#66534c2b
which can safely be ignored
- package meets naming guidelines
- package meets almost all packaging guidelines; it does not respect the
preferred buildroot, but this is not a blocker
- license is GPL, text (COPYING) is included in %doc, matches upstream
- spec file legible, in am. english 
- sha1sum 7319dcb1cbbfdff5fb5fb73cd2af92695732a36e matches upstream
- locale included via %{perl_vendorlib}/Locale/Po4a
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc seems to affect runtime (could not test because package does
not build in my mock)
- no .la files
- based on spec examination, does not seem to own files or directories already
owned by other packages
- no need for .desktop file


Should
- mock build for i386/fc6&devel fails with "Cannot find build req
perl(Text::WrapI18N). Exiting."

Maybe I should add something to the repo list in mock? I have tested both fc6
and devel, with core, extras and plague-results included.

> - nothing in %doc seems to affect runtime (could not test because package
> does not build in my mock)

> - mock build for i386/fc6&devel fails with "Cannot find build
> req perl(Text::WrapI18N). Exiting."

That's because this package depends on two not-yet-includes perl packages that
have been sumitted as well (follow the "blocked by" entries).

> Maybe I should add something to the repo list in mock? I have tested both fc6
> and devel, with core, extras and plague-results included.

You can build the two dependencies (note that they depend on each-other, so the
order matters) and add them to the setup. If you're lazy you can use the
pre-built packages for them I placed into ATrpms, but building yourself would be
preferred (and even better would it be to get them reviewed, too :).

Thanks!

OK, I will try to review them, although I am quite parallel with Perl.

(In reply to comment #2)
> Should
> - mock build for i386/fc6&devel fails with "Cannot find build req
> perl(Text::WrapI18N). Exiting."
> 
> Maybe I should add something to the repo list in mock? I have tested both fc6
> and devel, with core, extras and plague-results included.
> 

(In reply to comment #3)
> 
> That's because this package depends on two not-yet-includes perl packages 
> that
> have been sumitted as well (follow the "blocked by" entries).

FYI:
I attach here a comment which was sent to other person
who asked me about a same situation.

======================================================
There may be many cases in which you have to use packages
which are not imported into FE yet for mockbuild.
This can be done by following (I write for my case)


1. yum install createrepo
2. Create some directory. For my case,

   mkdir -p /var/lib/mock/LOCALRPMS/{i386,SRPMS}
3. put binary rpms into /var/lib/mock/LOCALRPMS/i386,
   srpm into /var/lib/mock/LOCALRPMS/SRPMS
4. cd /var/lib/mock/LOCALRPMS/i386
   createrepo $(pwd)

   Then repodata directory is created and some files
   are created under the directory
5. Change the permissions so that all files under
   /var/lib/mock/LOCALRPMS can be read by users
   who want to use mockbuild
6. Add the following to config file in /etc/mock
--------------------------------------------------
[LOCAL]
name=LOCAL
baseurl=file:///var/lib/mock/LOCALRPMS/i386/

--------------------------------------------------

Then you can use rpms under /var/lib/mock/LOCALRPMS/i386
for mockbuild

Thanks, Mamoru. If this happens often (and I guess it does) maybe the above is
worth while to get into the wiki? Then we can just point people to this page.

(In reply to comment #6)
> Thanks, Mamoru. If this happens often (and I guess it does) maybe the above is
> worth while to get into the wiki? Then we can just point people to this page.

Well, then I will try to add about this first on my wiki
pages.

I'll continue reviewing this one ASAP, probably Sunday

Continuing review from where I have left it:

MUST
- successfully builds in mock for i386 (with two (identical) warnings: Use of
uninitialized value in concatenation (.) or string at
/usr/lib/perl5/vendor_perl/5.8.8/Module/Build/Base.pm line 3450.)
- locale handled by %find_lang %{name} [1]
- seems to own all files it creates, does not own foreign files
- no scriptlets included

SHOULD
- includes translations for supported Non-English languages
- compiles and builds in mock/devel, results as no-arch package
- runs on FC6

[1] in the build log I see plenty of lines similar to
  it: 276 translated messages, 78 fuzzy translations, 717 untranslated messages.
  ca: 826 translated messages, 85 fuzzy translations, 160 untranslated messages.


Assuming the warnings issued at compile time are not dangerous [although I think
upstream should be bugged for a fix] this package is APPROVED

Thanks, package imported, built for devel and CVS branches requested.