Bug 2209775 - Review Request: golang-github-bep-simplecobra - A simpler API for the popular Cobra CLI
Summary: Review Request: golang-github-bep-simplecobra - A simpler API for the popular...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maverick Kaung
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2209669
TreeView+ depends on / blocked
 
Reported: 2023-05-24 18:03 UTC by W. Michael Petullo
Modified: 2023-06-02 20:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-02 20:10:28 UTC
Type: ---
Embargoed:
mavjs01: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-05-24 18:03:57 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-simplecobra.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-simplecobra-0.3.1-1.fc38.src.rpm
Description: A simpler API for the popular Cobra CLI.
Fedora Account System Username: mikep

Comment 1 Maverick Kaung 2023-05-30 18:06:26 UTC
Golang Package Review
==============
Note: Most of the heavy lifting is done by go2rpm

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The SPEC file looks sane.
- [x] Latest version is packaged.
- [x] License field in the package spec file matches the actual license, and it uses correct identifiers.
- [x] The package builds successfully in mock. (done via fedora-review)
- [x] Package successfully compiles and builds into binary rpms on at least one supported primary architecture. (done via fedora-review)
- [x] Package installs properly. (done via fedora-review)
- [x] Rpmlint is run on all rpms the build produces. (done via fedora-review)
- [x] The package runs tests in %check. (done via fedora-review)
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default, this is however a library)
- [x] The package complies with the Golang and general Packaging Guidelines.
- [x] hugo is built for golang exclusive arch, therefore `%gometa -f` is justified here as well.

Package approved!

Looking at the packages you maintain, I believe you already know the drill, however, just a small reminder to do the following on import:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package

Thank you for your continued contributions!

Comment 2 W. Michael Petullo 2023-05-30 23:38:51 UTC
https://pagure.io/releng/fedora-scm-requests/issue/53626

Comment 3 Fedora Admin user for bugzilla script actions 2023-05-31 05:46:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-simplecobra

Comment 4 Fedora Update System 2023-06-02 20:07:35 UTC
FEDORA-2023-ec790efd96 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ec790efd96

Comment 5 Fedora Update System 2023-06-02 20:10:28 UTC
FEDORA-2023-ec790efd96 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.