Spec URL: https://cra.fedorapeople.org/perl-Crypt-Argon2/perl-Crypt-Argon2.spec SRPM URL: https://cra.fedorapeople.org/perl-Crypt-Argon2/perl-Crypt-Argon2-0.019-1.fc37.src.rpm Description: This module implements the Argon2 key derivation function, which is suitable to convert any password into a cryptographic key. This is most often used to for secure storage of passwords but can also be used to derive a encryption key from a password. It offers variable time and memory costs as well as output size. Fedora Account System Username: cra
Hi Charles, There are some issues: 1) We not need line "Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))" BTW: When you look at REQUIRES field in your version of a final package you could see doubled "perl(:MODULE_COMPAT_5.36.1)", one is autogenerated, and second from you. 2) You could remove all Requires fields, that are autogenerated by perl-generators. And Exporter with version is autogenerated too because the version is placed in code. BTW: You could check this in REQUIRES field 3) You need to add coreutils to BuildRequires because there is the usage of chmod in %{_fixperms} macro 4) There is missing BuildRequire for File::Spec which is used in Build.PL Optional: We are recommending writing BuildRequires with sections (build, runtime, and test) and comment each section. Like https://src.fedoraproject.org/rpms/perl-HTTP-Cookies/blob/rawhide/f/perl-HTTP-Cookies.spec . This is better to understand what BuildRequire is from which activity.
Spec URL: https://cra.fedorapeople.org/perl-Crypt-Argon2/perl-Crypt-Argon2.spec SRPM URL: https://cra.fedorapeople.org/perl-Crypt-Argon2/perl-Crypt-Argon2-0.019-2.fc37.src.rpm Thank you. I fixed all the issues you brought up: (In reply to Michal Josef Spacek from comment #1) > 1) We not need line "Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} > -V:version`"; echo $version))" > BTW: When you look at REQUIRES field in your version of a final package you > could see doubled "perl(:MODULE_COMPAT_5.36.1)", one is autogenerated, and > second from you. > 2) You could remove all Requires fields, that are autogenerated by > perl-generators. And Exporter with version is autogenerated too because the > version is placed in code. > BTW: You could check this in REQUIRES field > 3) You need to add coreutils to BuildRequires because there is the usage of > chmod in %{_fixperms} macro > 4) There is missing BuildRequire for File::Spec which is used in Build.PL > > Optional: > We are recommending writing BuildRequires with sections (build, runtime, and > test) and comment each section. Like > https://src.fedoraproject.org/rpms/perl-HTTP-Cookies/blob/rawhide/f/perl- > HTTP-Cookies.spec . This is better to understand what BuildRequire is from > which activity.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Crypt-Argon2-0.019-2.fc39.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 glibc >= 2.37.9000-10 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.25)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.38)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6()(64bit) 1 perl(Crypt::Argon2) 1 perl(Exporter) >= 5.57 1 perl-libs 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires are Ok. $ rpm -qp --provides perl-Crypt-Argon2-0.019-2.fc39.x86_64.rpm | sort | uniq -c 1 perl-Crypt-Argon2(x86-64) = 0.019-2.fc39 1 perl(Crypt::Argon2) = 0.019 1 perl-Crypt-Argon2 = 0.019-2.fc39 Binary provides are Ok. $ rpmlint ./perl-Crypt-Argon2* 4 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-Argon2
FEDORA-2023-d717995379 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d717995379
FEDORA-2023-0d75dc90cf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0d75dc90cf
FEDORA-2023-d717995379 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d717995379 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d717995379 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-0d75dc90cf has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0d75dc90cf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0d75dc90cf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-0d75dc90cf has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-d717995379 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.