Spec URL: http://odysseus.x-tnd.be/fedora/moodin/ksplash-engine-moodin.spec SRPM URL: http://odysseus.x-tnd.be/fedora/moodin/ksplash-engine-moodin-0.4.2-0.2.fc6.src.rpm Description: Moodin is a splash engine for KDE Desktop
*** Bug 221016 has been marked as a duplicate of this bug. ***
(In reply to comment #0) SRPM URL: http://odysseus.x-tnd.be/fedora/moodin/ksplash-engine-moodin-0.4.2-1.fc6.src.rpm Changed release from 0.2 to 1
This is not an official review, I'm looking for a sponsor. I think you should use %{name} and %{version} macros in Source0. * rpmlint is silent for RPM & SRPM * source files match upstream * specfile is properly named * BuildRequires listed well (mock builds successfully on FC6 i386) * latest version is being packaged * license field matches the actual license (included in %doc)
Can't do an official Review as i can't sponsor you. MUST : - The .la libtool archives must be removed in the spec. - The %{name}.desktop file must be properly installed with desktop-file-install in the %install section, see http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
(In reply to comment #4) > - The %{name}.desktop file must be properly installed with desktop-file-install > in the %install section, see > http://fedoraproject.org/wiki/Packaging/Guidelines#desktop In this case, the desktop file on the kmenu can be neglected since the desktop coming with the package is for kcontrol and not for kmenu. However kdmtheme will be following that direction for its next update. Fedora's default Kmenu is by far too huge and crowded, let's not dump anything onto it. My mom will be confused having her kmenu on her fedora that huge.
In this case, in agreement with Chitlesh, the items from comment #4 are inaccurate. See also http://fedoraproject.org/wiki/PackagingDrafts/LibtoolArchives for when it is appropriate (imo, not official, yet, mind you) to remove .la files.
(In reply to comment #6) > In this case, in agreement with Chitlesh, the items from comment #4 are > inaccurate. See also > http://fedoraproject.org/wiki/PackagingDrafts/LibtoolArchives > for when it is appropriate (imo, not official, yet, mind you) to remove .la files. Well again that FE guideline as well may not apply here. withOUT the .la file, I have this: http://www.flickr.com/photo_zoom.gne?id=348320132&size=o with the .la file, I have this: http://www.flickr.com/photo_zoom.gne?id=348320133&size=o I guess the 2 items mentioned by Remi which are indeed FE guidelines, may not be applied here with this ksplash-engine-moodin package (if not they will break the package).
In changelog: - removed kdelibs-devel from BR wich is already required by kdebase-devel There is a typo :) "which" with a "h"
Thanks :) * Tue Jan 02 2007 Johan Cwiklinski <johan.cwiklinski> 0.4.2-2 - using 'name' and 'version' macros for Source0 - corrected mispelling in changelog SRPM URL : http://odysseus.x-tnd.be/fedora/moodin/ksplash-engine-moodin-0.4.2-2.fc6.src.rpm
Hi. Some time ago I've made(*) a splash screen with the fc6 artwork. Perhaps it would be worth to think about an inclusion in the package? Otherwise just ignore this comment. :) https://www.redhat.com/archives/fedora-art-list/2006-November/msg00145.html * I'm not an artist. The screen works for me (tm) but surely needs some enhancement. :)
Hello Sebastin, I don't think It should be integrated within this package "ksplash-engine-moodin". but however you can create another package "ksplash-moodin-theme-MYTHEME.spec for the themes on: Johan Cwiklinski has been working on some themes for moodin as a seperate package which depends on this "ksplash-engine-moodin". see http://odysseus.x-tnd.be/fedora/moodin/themes/ksplash-moodin-theme-curcuit.spec as example. Try to work on yours and ask for another review and add me in Cc: for that bug:)
(In reply to comment #11) > Try to work on yours and ask for another review and add me in Cc: for that bug:) ok, you're right. :) I will wait until this package is approved and then create a single addon for it.
Ok, I'm sponsoring.
MUST Items: - MUST: The package is named according to the Package Naming Guidelines. - MUST: The package meets the Packaging Guidelines. - MUST: The package is licensed (GPL) with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. - MUST: The License field in the package spec file matches the actual license. - MUST: the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. - MUST: The spec file must be written in American English. - MUST: The sources used to build the package must matches the upstream source, as provided in the spec URL. - MUST: The package successfully compiles and builds into binary rpms on at least i386. - MUST: All build dependencies is listed in BuildRequires. - MUST: The spec file handles locales properly. - MUST: If the package does not contain shared library files located in the dynamic linker's default paths - MUST: the package is not designed to be relocatable - MUST: the package owns all directories that it creates. - MUST: the package does not contain any duplicate files in the %files listing. - MUST: Permissions on files are set properly. - MUST: The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - MUST: The package consistently uses macros, as described in the macros section of Packaging Guidelines. - MUST: The package contains code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines. - MUST: There are no Large documentation files - MUST: %doc does not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. - MUST: The package does not contain library files with a suffix - MUST: Package containing GUI applications includes a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. - MUST: Package does not own files or directories already owned by other packages. SHOULD Items: - SHOULD: The source package does include license text(s) as COPYING - SHOULD: mock builds succcessfully in i386. - SHOULD: The reviewer tested that the package functions as described. A package should not segfault instead of running, for example. - SHOULD: No scriptlets were used, those scriptlets must be sane. - SHOULD: No subpackages present. APPROVED!
Follow http://fedoraproject.org/wiki/CVSAdminProcedure for the CVS Request procedure. As we agreed, add me as your co-maintainer.
New Package CVS Request ======================= Package Name: ksplash-engine-moodin Short Description: Moodin is a splash engine for KDE Desktop Owners: johan, cgoorah.au Branches: FC-5 FC-6 devel InitialCC: