Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-1.src.rpm Description: cowsay is a configurable talking cow, written in Perl. It operates much as the figlet program does, and it written in the same spirit of silliness. It generates ASCII pictures of a cow with a message. It can also generate pictures of other animals. rpmlint gives following output: W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp but that same output is given on rpmlint.rpm so it looks like we can ignore it.
Actually I know this application because I use this for cowsaver, one of hacks which can be used for xscreensaver. I will review this. * Use "cp -p" to keep timestamps ("Timestamps" in http://fedoraproject.org/wiki/Packaging/Guidelines ) * Please fix the description of man package according to installed paths. * How about randomize a cow which is choosen?
Created attachment 144618 [details] wrapper script I use to randomize cowsay c.f. "animalsay", which I use for cowsaver to randomize animal used by cowsay.
Thanks for review! I have uploaded new SRPM and Spec files: Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-2.src.rpm I hope it's good enough right now :)
[tasaka1@localhost cowsay]$ cat 1.log | animalsay -W 100 _____________________________________________________________________________________________________ / Thank you for adding my "animalsay" script!! \ | | | Well, = rpmlint issue | | | | W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp | | | | = This _must_ be ignored for this case. = Timestamps, man file description are now okay. = License, | | md5sum okay = Other things are also okay... accroding to | | | | http://fedoraproject.org/wiki/Packaging/Guidelines | | | | http://fedoraproject.org/wiki/Packaging/ReviewGuidelines | | | | ----------------------------------------------------------- | | | \ This package (cowsay) is APPROVED by me. / ----------------------------------------------------------------------------------------------------- \ ____ \ / \ | ^__^ | | (oo) |______ | (__) | )\/\ \____/|----w | || || Moofasa
_____________________________________________________ / I had to slightly modify animalsay script ;-) \ | | | Thank you again for review! | | | | Package succesfully built for FC-5, FC-6 and devel. | | | \ Closing. / ----------------------------------------------------- \ \ .--. |o_o | |:_/ | // \ \ (| | ) /'\_ _/`\ \___)=(___/
Package Change Request ====================== Package Name: cowsay Updated EPEL Owners: jstanley New Branches: EL-4 EL-5 ____________ < Thank You! > ------------ \ \ .--. |o_o | |:_/ | // \ \ (| | ) /'\_ _/`\ \___)=(___/
cvs done.