Bug 2211278 (review-rust-powierza-coefficient) - Review Request: rust-powierza-coefficient - Powierza coefficient for gauging string abbreviations
Summary: Review Request: rust-powierza-coefficient - Powierza coefficient for gauging ...
Keywords:
Status: CLOSED ERRATA
Alias: review-rust-powierza-coefficient
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: itp-rust-nu-command
TreeView+ depends on / blocked
 
Reported: 2023-05-31 02:35 UTC by Michel Lind
Modified: 2023-06-22 02:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-06-22 02:26:53 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-31 02:35:02 UTC
Spec URL: https://salimma.fedorapeople.org/rust-powierza-coefficient.spec
SRPM URL: https://salimma.fedorapeople.org/rust-powierza-coefficient-1.0.2-1.fc39.src.rpm

Description:
Powierża coefficient is a statistic for gauging if one string is an
abbreviation of another.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-06-06 19:46:11 UTC
Looks good to me with two minor issues:

* no comment / justification for the patch(es) (i.e. something like "criterion dependency is unused, include LICENSE file in installed files")
* Summary is too long, please trim it to sensible length ... and maybe it would be a good idea to only use ASCII in the Summary (but I think it's fine to use UTF-8 in the %description)

Comment 3 Fabio Valentini 2023-06-09 19:45:25 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (submitted to upstream)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-06-13 10:41:48 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-powierza-coefficient

Comment 5 Fedora Update System 2023-06-13 17:28:27 UTC
FEDORA-2023-048ca96ddc has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-048ca96ddc

Comment 6 Fedora Update System 2023-06-13 17:28:28 UTC
FEDORA-EPEL-2023-14f918e807 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-14f918e807

Comment 7 Fedora Update System 2023-06-14 00:59:41 UTC
FEDORA-EPEL-2023-14f918e807 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-14f918e807

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-06-14 02:32:23 UTC
FEDORA-2023-048ca96ddc has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-048ca96ddc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-048ca96ddc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-06-14 03:00:37 UTC
FEDORA-2023-8d08e90d17 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8d08e90d17 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d08e90d17

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-06-22 02:26:53 UTC
FEDORA-2023-048ca96ddc has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-06-22 02:37:53 UTC
FEDORA-2023-8d08e90d17 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-06-22 02:42:31 UTC
FEDORA-EPEL-2023-14f918e807 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.