Spec URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d-0.2.6-1.src.rpm Description: QwtPlot3D is not a program, but a feature-rich Qt/OpenGL-based C++ programming library, providing essentially a bunch of 3D-widgets for programmers It is needed at least by LabPlot. I have managed to get rpmlint silent apart from one, harmless error. Package builds in mock (fc6/i386).
(In reply to comment #0) > It is needed at least by LabPlot. I have managed to get rpmlint silent apart from one, harmless error. Package builds in mock (fc6/i386). On fc6/x86_64 it builds as well. I'll make a full review later.
REVIEW: * rpmlint is not quiet: E: qwtplot3d-devel only-non-binary-in-usr-lib but we can ignore that until a file in /usr/lib is symlink to a binary one * sources match upstream (7ef960d7874f78162d6c9d241de2843e) * BRs listed well (mock builds fine) * license is in fact zlib/libpng (checked) !* -devel subpackage present, but needs to be improved * name of package is good as well as spec file name * proper %post and %postun sections * package isn't designed to be relocatable * there's no duplicates in %files section * package owns files and directories well * proper %clean section * %defattr macros are present * macros are used good THING TO DO: - some header files include files like a qstringlist.h which are owned by qt-devel package. Thus you have to add qt-devel dependency to -devel subpackage.
Spec URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d-0.2.6-2.src.rpm New release: - Added qt-devel to -devel subpackage requires
Nothing to pick on. Approved.
Package Change Request ====================== Package Name: qwtplot3d Updated Fedora Owners: chitlesh
I don't see that email address in the account system? Can you check it and resubmit?
Oops, sorry. Package Change Request ====================== Package Name: qwtplot3d Updated Fedora Owners: cgoorah.au
Thanks. cvs done.
Package Change Request ====================== Package Name: qwtplot3d New Branches: EL-6 Owners: chitlesh
CVS done (by process-cvs-requests.py).