Spec URL: https://download.copr.fedorainfracloud.org/results/torbuntu/mobile-testing/fedora-rawhide-aarch64/05739124-phosh-mobile-settings/phosh-mobile-settings.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/torbuntu/mobile-testing/fedora-rawhide-aarch64/05739124-phosh-mobile-settings/phosh-mobile-settings-0.26.0-1.fc39.src.rpm Description: Mobile Settings App for phosh and related components Fedora Account System Username: Torbuntu
I'll review this. Look for a few review soon.
Issues: ======= - if you're using autochangelog, just replace the placeholder John Doe one with %autochangelog? - Might add appstream-devel to BuildRequires? I see in the build log: Program appstreamcli found: NO - rpmlint doesn't like the .desktop file: phosh-mobile-settings.x86_64: E: invalid-desktopfile /usr/share/applications/org.sigxcpu.MobileSettings.desktop value "Phosh;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Phosh"; values extending the format should start with "X-" But I think thats fine for now. - Should own /usr/lib64/phosh-mobile-settings and /usr/lib64/phosh-mobile-settings/plugins dirs in files. Just add as %dir or only specify %{_libdir}/phosh-mobile-settings in files. - minor nitpicks: phosh-mobile-settings.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 6) might drop %check since there's no tests run here? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "GNU General Public License, Version 3". 55 files have unknown license. Detailed output of licensecheck in /home/kevin/2211644-phosh-mobile-settings/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/phosh-mobile-settings/plugins, /usr/lib64/phosh-mobile-settings [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/phosh-mobile- settings/plugins, /usr/lib64/phosh-mobile-settings [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [?]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: phosh-mobile-settings-0.26.0-1.fc39.x86_64.rpm phosh-mobile-settings-debuginfo-0.26.0-1.fc39.x86_64.rpm phosh-mobile-settings-debugsource-0.26.0-1.fc39.x86_64.rpm phosh-mobile-settings-0.26.0-1.fc39.src.rpm =================================== rpmlint session starts =================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3ftsp6j1')] checks: 31, packages: 4 phosh-mobile-settings.x86_64: W: no-manual-page-for-binary phosh-mobile-settings phosh-mobile-settings.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 6) phosh-mobile-settings.x86_64: E: invalid-desktopfile /usr/share/applications/org.sigxcpu.MobileSettings.desktop value "Phosh;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Phosh"; values extending the format should start with "X-" ==== 4 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.7 s ==== Rpmlint (debuginfo) ------------------- Checking: phosh-mobile-settings-debuginfo-0.26.0-1.fc39.x86_64.rpm =================================== rpmlint session starts =================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptijs5w27')] checks: 31, packages: 1 ==== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ==== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 phosh-mobile-settings.x86_64: W: no-manual-page-for-binary phosh-mobile-settings phosh-mobile-settings.x86_64: E: invalid-desktopfile /usr/share/applications/org.sigxcpu.MobileSettings.desktop value "Phosh;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Phosh"; values extending the format should start with "X-" 3 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.8 s Unversioned so-files -------------------- phosh-mobile-settings: /usr/lib64/phosh-mobile-settings/plugins/libms-plugin-librem5.so Source checksums ---------------- https://gitlab.gnome.org/guidog/phosh-mobile-settings/-/archive/v0.26.0/phosh-mobile-settings-v0.26.0.tar.gz : CHECKSUM(SHA256) this package : ebddd44375c5cbfe2056598f9481635fa42ba2139782ebc43846530c728eb9b8 CHECKSUM(SHA256) upstream package : ebddd44375c5cbfe2056598f9481635fa42ba2139782ebc43846530c728eb9b8 Requires -------- phosh-mobile-settings (rpmlib, GLIBC filtered): libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libsensors.so.4()(64bit) libwayland-client.so.0()(64bit) rtld(GNU_HASH) phosh-mobile-settings-debuginfo (rpmlib, GLIBC filtered): phosh-mobile-settings-debugsource (rpmlib, GLIBC filtered): Provides -------- phosh-mobile-settings: application() application(org.sigxcpu.MobileSettings.desktop) libms-plugin-librem5.so()(64bit) metainfo() metainfo(org.sigxcpu.MobileSettings.metainfo.xml) phosh-mobile-settings phosh-mobile-settings(x86-64) phosh-mobile-settings-debuginfo: debuginfo(build-id) libms-plugin-librem5.so-0.26.0-1.fc39.x86_64.debug()(64bit) phosh-mobile-settings-debuginfo phosh-mobile-settings-debuginfo(x86-64) phosh-mobile-settings-debugsource: phosh-mobile-settings-debugsource phosh-mobile-settings-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2211644 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, Ocaml, Python, Java, PHP, Haskell, SugarActivity, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review! I believe I've addressed the issues. SPEC: https://download.copr.fedorainfracloud.org/results/torbuntu/mobile-testing/fedora-rawhide-x86_64/06076913-phosh-mobile-settings/phosh-mobile-settings.spec SRPM:https://download.copr.fedorainfracloud.org/results/torbuntu/mobile-testing/fedora-rawhide-x86_64/06076913-phosh-mobile-settings/phosh-mobile-settings-0.26.0-1.fc39.src.rpm
Looks good. APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/phosh-mobile-settings