Spec URL: https://gitlab.com/t0xic0der/firmitas/-/raw/main/firmitas.spec SRPM URL: https://gitlab.com/t0xic0der/firmitas/uploads/50a7fff133ecabb2497b76a462108c57/firmitas-0.1.1-1.el9.src.rpm Description: Simple notification service for X.509-standard TLS certificate statuses Fedora Account System Username: t0xic0der
I am taking this package to review
I changed package name into "python-firmitas" based on Fedora Python guidelines and I made PR for bunch of fixes in spec file as well. https://gitlab.com/t0xic0der/firmitas/-/merge_requests/6 Also please update Spec URL after PR merged. (file name also change renamed)
I saw PR merged and rest of them also LGTM so package approved !
https://gitlab.com/t0xic0der/firmitas/-/merge_requests/6 is now merged. Thanks for your attention, @thunderbirdtr
Here are a few more fixes for the review. https://gitlab.com/t0xic0der/firmitas/-/merge_requests/7 I also noticed that this fails to build on Rawhide due to an upper bound on cryptography in the source. I believe new packages must successfully build on Rawhide to pass review. I sent a separate PR to raise that upper bound. https://gitlab.com/t0xic0der/firmitas/-/merge_requests/8
Thanks @carl for creating those pull requests! I have reviewed, approved and merged them.
The Pagure repository was created at https://src.fedoraproject.org/rpms/firmitas