As seen in https://artifacts.dev.testing-farm.io/03533289-6f2e-43cc-a169-5d4a793d8ae0/ annocheck reports fortify as failed in i686 binaries with one of these two messages: -------------- Hardened: /usr/bin/valgrind: FAIL: fortify test because no indication that the necessary option was used (and a C compiler was detected) (source: final scan) ----- or ----- Hardened: /usr/bin/valgrind-listener: FAIL: fortify test because -D_FORTIFY_SOURCE=[2|3] was not present on the command line (function: setsockopt) (source: annobin notes) -------------- The binaries are coming from valgrind-3.21.0-5.fc39 (https://koji.fedoraproject.org/koji/buildinfo?buildID=2207502). However this test passes for the binaries inside valgrind-3.21.0-4.fc39 (https://koji.fedoraproject.org/koji/buildinfo?buildID=2202010), and these were compiled and linked with the exact same flags. I also ran annocheck directly on the files of both valgrind builds to check that this is not caused by rpminspect: -------------- [/var/tmp/rpminspect/local.lbRZ70/root] $ annocheck --ignore-unknown --skip-lto --profile=rawhide after/i686/usr/bin/valgrind --debug-file=after/i686/usr/lib/debug/usr/bin/valgrind-3.21.0-5.fc39.i386.debug annocheck: Version 12.10. Hardened: using profile: rawhide. Hardened: valgrind: FAIL: fortify test because no indication that the necessary option was used (and a C compiler was detected) Hardened: Rerun annocheck with --verbose to see more information on the tests. Hardened: valgrind: Overall: FAIL. [/var/tmp/rpminspect/local.lbRZ70/root] $ annocheck --ignore-unknown --skip-lto --profile=rawhide before/i686/usr/bin/valgrind --debug-file=before/i686/usr/lib/debug/usr/bin/valgrind-3.21.0-4.fc39.i386.debug annocheck: Version 12.10. Hardened: using profile: rawhide. Hardened: valgrind: PASS. -------------- Reproducible: Always Steps to Reproduce: 1. rpminspect-fedora -v -a i686 -T annocheck valgrind-3.21.0-5.fc39 Actual Results: fortify test failed in /usr/bin/valgrind, /usr/bin/valgrind-listener, /usr/bin/vgdb Expected Results: fortify test pass.
The problem is that the new annobin string notes have been moved into the separate debuginfo file, but annocheck was not examining it...
Should be fixed in annobin-12.12-1.fc39
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle. Changing version to 39.
This message is a reminder that Fedora Linux 39 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 39 on 2024-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '39'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 39 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
Fedora Linux 39 entered end-of-life (EOL) status on 2024-11-26. Fedora Linux 39 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora Linux please feel free to reopen this bug against that version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see the version field. If you are unable to reopen this bug, please file a new report against an active release. Thank you for reporting this bug and we are sorry it could not be fixed.