Bug 2212224 - Review Request: rust-smart-default - Rust custom-derive macro for Default with more control on the fields
Summary: Review Request: rust-smart-default - Rust custom-derive macro for Default wit...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2212222
TreeView+ depends on / blocked
 
Reported: 2023-06-04 21:16 UTC by Aleksei Bavshin
Modified: 2023-06-08 14:40 UTC (History)
2 users (show)

Fixed In Version: rust-smart-default-0.6.0-10.fc39
Clone Of:
Environment:
Last Closed: 2023-06-08 14:40:39 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2023-06-04 21:16:36 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/tuigreet/rust-smart-default.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/tuigreet/rust-smart-default-0.6.0-1.fc38.src.rpm
Description:
Rust custom-derive macro for Default with more control on the fields

Fedora Account System Username: alebastr

Notes:
 * unretirement of an existing package currently maintained by @atim
 * tuigreet depends on ^0.6, but 0.7.1 is supposed to be fully compatible (syn 1 -> syn 2 upgrade is an internal implementation detail).
   No preference regarding the packaged version, except that I don't want to break anything in f37.

Comment 1 Fabio Valentini 2023-06-06 20:11:42 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (reason given)
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

=== 

You can proceed with the unretirement. I have no strong feelings regarding the version, if anything ever depended on it, it was probably starship, and it was retired from f37+.

Comment 2 Aleksei Bavshin 2023-06-08 14:40:39 UTC
Thanks for the review!

Unretired and built for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d862e766e1


Note You need to log in before you can comment on or make changes to this bug.