RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2212772 - Do not allow selecting specific cipher implementation in libcryptsetup
Summary: Do not allow selecting specific cipher implementation in libcryptsetup
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cryptsetup
Version: 8.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: rc
: 8.9
Assignee: Daniel Zaťovič
QA Contact: guazhang@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-06 10:10 UTC by Ondrej Kozina
Modified: 2023-11-14 18:12 UTC (History)
5 users (show)

Fixed In Version: cryptsetup-2.3.7-7.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-14 15:51:13 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab cryptsetup cryptsetup issues 809 0 None closed Unsigned header allows attacker to choose vulnerable AES implementation in untrusted cloud host setting 2023-06-06 10:10:12 UTC
Red Hat Issue Tracker RHELPLAN-159061 0 None None None 2023-06-06 10:14:45 UTC
Red Hat Product Errata RHBA-2023:7161 0 None None None 2023-11-14 15:51:17 UTC

Description Ondrej Kozina 2023-06-06 10:10:13 UTC
This bug was initially created as a copy of Bug #2212771

I am copying this bug because: 



Description of problem:

Libcryptsetup should not allow selecting specific cipher implementation when using 'capi' cipher format. For example aes-generic is SW implementation of AES cipher in kernel that does not use HW acceleration specific to available CPU.

Selecting specific cipher implementation should always be delegated to kernel crypto layer. This may allow loading cipher implementations that are susceptible to side-channel attacks on volume keys.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. cryptsetup luksFormat -c 'capi:xts(ecb(aes-generic))-plain64' /dev/device
2. cryptsetup open /dev/device

Actual results:
It passes in both step 1) and step 2)

Expected results:
Neither luksFormat or subsequent open commands shall pass. It also applies on LUKS2 headers previously formated/changed to use aes-generic implementation in kernel.

Additional info:
aes-generic driver is AES software implementation using lookup tables, susceptible to side-channel attacks.

Comment 2 guazhang@redhat.com 2023-07-11 08:15:42 UTC

cryptsetup-2.3.7-5.el8.x86_64
[root@lenovo-electron-sr850-01 ~]# cryptsetup luksFormat -c 'capi:xts(ecb(aes-generic))-plain64' t.tar  -q
Enter passphrase for t.tar: 
[root@lenovo-electron-sr850-01 ~]# $?
-bash: 0: command not found
[root@lenovo-electron-sr850-01 ~]# 

cryptsetup-2.3.7-6.el8.x86_64
[root@amd-genoa-05 ~]# cryptsetup luksFormat -c 'capi:xts(ecb(aes-generic))-plain64' t.tar
No known cipher specification pattern detected.
[root@amd-genoa-05 ~]# $?
-bash: 1: command not found
[root@amd-genoa-05 ~]# 


so the fixed package has fixed the error.

Comment 6 errata-xmlrpc 2023-11-14 15:51:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cryptsetup bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7161


Note You need to log in before you can comment on or make changes to this bug.