Description of problem: [Machines] vCPU and CPU topology settings could not be saved Version-Release number of selected components (if applicable): cockpit-machines-291-1.el9.noarch cockpit-292-1.el9.x86_64 libvirt-dbus-1.4.1-5.el9.x86_64 libvirt-client-9.3.0-2.el9.x86_64 How reproducible: 100% Steps to Reproduce: 1. Prepare a running VM like cirros, enter vm details page 2. Click edit after CPU in Overview tab, click apply without any changes. There is error on the dialog: vCPU and CPU topology settings could not be saved ERROR unsupported configuration: CPU topology doesn't match maximum vcpu count 3. Click Cancel, then click edit again, change Mode to a different value like host-model , click Apply The same error occurs, but the changes to the Mode is successful, there will be changes pending icon and the changes took effect after shut down the vm. 4. Click edit again, change vCPU count to 1, click Apply. Same error occurs, and the changes did not take effect. Actual results: As above. Expected results: No error occurs. Additional info:
https://github.com/cockpit-project/cockpit-machines/pull/1122
Verified with packages: cockpit-machines-293-1.el9.noarch cockpit-295-1.el9.x86_64 libvirt-dbus-1.4.1-5.el9.x86_64 libvirt-client-9.3.0-2.el9.x86_64 Steps: 1. Prepare a running VM like cirros, enter vm details page 2. Click edit after CPU in Overview tab, click apply without any changes. Dialog closed without error message. 3. Click edit again, change Mode to a different value like host-model , click Apply No error occurs, there will be changes pending icon and the changes took effect after shut down the vm. 4. Click edit again, change vCPU count to 1, click Apply. No error occurs, there will be changes pending icon and the changes took effect after shut down the vm. So verified.