Bug 2213214 - Review Request: rust-rfc6979 - Deterministic Usage of DSA and ECDSA (RFC6979)
Summary: Review Request: rust-rfc6979 - Deterministic Usage of DSA and ECDSA (RFC6979)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2213265
TreeView+ depends on / blocked
 
Reported: 2023-06-07 13:55 UTC by Fabio Valentini
Modified: 2023-06-08 18:09 UTC (History)
2 users (show)

Fixed In Version: rust-rfc6979-0.4.0-2.fc39
Clone Of:
Environment:
Last Closed: 2023-06-08 18:09:31 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-06-07 13:55:57 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-rfc6979.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-rfc6979-0.4.0-1.fc38.src.rpm

Description:
Pure Rust implementation of RFC6979: Deterministic Usage of the Digital
Signature Algorithm (DSA) and Elliptic Curve Digital Signature Algorithm
(ECDSA).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-07 13:56:00 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=101905960

Comment 2 Michel Lind 2023-06-08 16:07:16 UTC
Package was generated with rust2rpm, simplifying the review.

Nit: summary too long again -- and wrong (it cut off ECSA). Suggest changing to this when importing: "Pure Rust implementation of RFC6979: Deterministic Usage of DSA and ECDSA"

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fabio Valentini 2023-06-08 17:42:28 UTC
Thanks for the review! I'll update the Summary before import.

Comment 4 Fedora Admin user for bugzilla script actions 2023-06-08 17:43:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rfc6979

Comment 5 Fabio Valentini 2023-06-08 17:54:05 UTC
Meh, can't think today. Fixed it for real now (I hope).

Comment 6 Fabio Valentini 2023-06-08 18:09:31 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-50d09f0737


Note You need to log in before you can comment on or make changes to this bug.