Bug 2213746 - [Machines] Edit watchdog failed for undefined vm with not proper error messages
Summary: [Machines] Edit watchdog failed for undefined vm with not proper error messages
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: cockpit-machines
Version: 9.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 9.3
Assignee: Simon Kobyda
QA Contact: Xianghua Chen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-09 06:40 UTC by Xianghua Chen
Modified: 2023-07-05 09:11 UTC (History)
6 users (show)

Fixed In Version: cockpit-machines-293-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Watchdog error (262.39 KB, image/png)
2023-06-09 06:40 UTC, Xianghua Chen
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-160835 0 None None None 2023-06-26 19:32:58 UTC

Description Xianghua Chen 2023-06-09 06:40:27 UTC
Created attachment 1969870 [details]
Watchdog error

Description of problem:
[Machines] Edit watchdog failed for undefined vm with not proper error messages

Version-Release number of selected components (if applicable):
cockpit-machines-291-1.el9.noarch
cockpit-292-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog
There is a new bug for this : https://bugzilla.redhat.com/show_bug.cgi?id=2213740

4. Close the dialog, you will find the "Pause" is added successfully. 
Click edit again, select "Reset" this time, click "Save"


Actual results:
There will be 2 icons with error messages on the dialog:
1. Changes will take effect after shutting down the VM
2. Could not dynamically add watchdog
Adding a watchdog will require a reboot to take effect.

But no "Apply on next reboot" button for this.
Refer to screenshot.

Expected results:
Should be able to change watchdog at last, or at least provide proper error message and guide on this .

Additional info:

Comment 2 Simon Kobyda 2023-06-26 21:51:46 UTC
Fix merged: https://github.com/cockpit-project/cockpit-machines/pull/1118

Comment 5 Xianghua Chen 2023-07-05 09:11:34 UTC
Verified with packages:
cockpit-machines-293-1.el9.noarch
cockpit-295-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

Steps:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog
"Pause" added successfully

4. Click edit again
Save is disabled, and if move to it, there is a hint: "Cannot edit watchdog device on a transient VM"
Select "Reset" this time, save is still disabled.

So verified.


Note You need to log in before you can comment on or make changes to this bug.