Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=102060524 orphaned package: https://src.fedoraproject.org/rpms/qxmpp Description: QXmpp is a cross-platform C++ XMPP client and server library. It is written in C++ and uses Qt framework. QXmpp strives to be as easy to use as possible, the underlying TCP socket, the core XMPP RFCs (RFC6120 and RFC6121) and XMPP extensions have been nicely encapsulated into classes. QXmpp is ready to build XMPP clients complying with the XMPP Compliance Suites 2022 for IM and Advanced Mobile. It comes with full API documentation, automatic tests and some examples. Fedora Account System Username: topazus Reproducible: Always
update: Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=102203120
add license description and fix format Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm
enable BUILD_OMEMO cmake build option Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm
Fix license: Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/qxmpp See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Creative Commons CC0 1.0", "Creative Commons CC0 1.0 GNU Lesser General Public License v2.1 or later", "Unknown or generated", "*No copyright* Creative Commons CC0 1.0", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 2.1 GNU General Public License, Version 3 Creative Commons CC0 1.0". 17 files have unknown license. Detailed output of licensecheck in /home/dcantrell/reviews/qxmpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qxmpp- qt5 , qxmpp-qt5-devel , qxmpp-qt6 , qxmpp-qt6-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: qxmpp-qt5-1.5.5-1.fc39.x86_64.rpm qxmpp-qt5-devel-1.5.5-1.fc39.x86_64.rpm qxmpp-qt6-1.5.5-1.fc39.x86_64.rpm qxmpp-qt6-devel-1.5.5-1.fc39.x86_64.rpm qxmpp-doc-1.5.5-1.fc39.noarch.rpm qxmpp-debuginfo-1.5.5-1.fc39.x86_64.rpm qxmpp-debugsource-1.5.5-1.fc39.x86_64.rpm qxmpp-1.5.5-1.fc39.src.rpm ======================================================================= rpmlint session starts =====================================================================\ = rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpk833tu_7')] checks: 31, packages: 8 qxmpp-qt5-devel.x86_64: W: no-documentation qxmpp-qt6-devel.x86_64: W: no-documentation qxmpp-doc.noarch: W: files-duplicate /usr/share/doc/qxmpp/html/search/functions_18.js /usr/share/doc/qxmpp/html/search/all_18.js qxmpp-doc.noarch: W: files-duplicate /usr/share/doc/qxmpp/html/search/functions_19.js /usr/share/doc/qxmpp/html/search/all_19.js qxmpp-qt5-devel.x86_64: W: files-duplicate /usr/lib64/cmake/QXmppQt5/QXmppQt5ConfigVersion.cmake /usr/lib64/cmake/QXmppOmemoQt5/QXmppOmemoQt5ConfigVersion.cmake qxmpp-qt6-devel.x86_64: W: files-duplicate /usr/lib64/cmake/QXmppQt6/QXmppQt6ConfigVersion.cmake /usr/lib64/cmake/QXmppOmemoQt6/QXmppOmemoQt6ConfigVersion.cmake ======================================== 8 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 1.1 s ======================================\ = Rpmlint (debuginfo) ------------------- Checking: qxmpp-qt6-debuginfo-1.5.5-1.fc39.x86_64.rpm qxmpp-qt5-debuginfo-1.5.5-1.fc39.x86_64.rpm qxmpp-debuginfo-1.5.5-1.fc39.x86_64.rpm ======================================================================= rpmlint session starts =====================================================================\ = rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppqrlqhw9')] checks: 31, packages: 3 ======================================== 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.9 s ======================================\ = Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 qxmpp-qt6-devel.x86_64: W: no-documentation qxmpp-qt5-devel.x86_64: W: no-documentation qxmpp-qt6-devel.x86_64: W: files-duplicate /usr/lib64/cmake/QXmppQt6/QXmppQt6ConfigVersion.cmake /usr/lib64/cmake/QXmppOmemoQt6/QXmppOmemoQt6ConfigVersion.cmake qxmpp-qt5-devel.x86_64: W: files-duplicate /usr/lib64/cmake/QXmppQt5/QXmppQt5ConfigVersion.cmake /usr/lib64/cmake/QXmppOmemoQt5/QXmppOmemoQt5ConfigVersion.cmake qxmpp-doc.noarch: W: files-duplicate /usr/share/doc/qxmpp/html/search/functions_18.js /usr/share/doc/qxmpp/html/search/all_18.js qxmpp-doc.noarch: W: files-duplicate /usr/share/doc/qxmpp/html/search/functions_19.js /usr/share/doc/qxmpp/html/search/all_19.js 9 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 1.1 s Source checksums ---------------- https://github.com/qxmpp-project/qxmpp/archive/v1.5.5/qxmpp-1.5.5.tar.gz : CHECKSUM(SHA256) this package : b25fba89432c4fd72489d1844f683bfbf4e5aa4cfcfda7a982d6019f8e4529f8 CHECKSUM(SHA256) upstream package : b25fba89432c4fd72489d1844f683bfbf4e5aa4cfcfda7a982d6019f8e4529f8 Requires -------- qxmpp-qt5 (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libQXmppQt5.so.4()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libomemo-c.so.0()(64bit) libqca-qt5.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) qxmpp-qt5-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libQXmppOmemoQt5.so.4()(64bit) libQXmppQt5.so.4()(64bit) pkgconfig(QXmppQt5) qxmpp-qt5(x86-64) qxmpp-qt6 (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libQXmppQt6.so.4()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.5)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Xml.so.6()(64bit) libQt6Xml.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libomemo-c.so.0()(64bit) libqca-qt6.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) qxmpp-qt6-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libQXmppOmemoQt6.so.4()(64bit) libQXmppQt6.so.4()(64bit) pkgconfig(QXmppQt5) qxmpp-qt6(x86-64) qxmpp-doc (rpmlib, GLIBC filtered): qxmpp-debuginfo (rpmlib, GLIBC filtered): qxmpp-debugsource (rpmlib, GLIBC filtered): Provides -------- qxmpp-qt5: libQXmppOmemoQt5.so.4()(64bit) libQXmppQt5.so.4()(64bit) qxmpp-qt5 qxmpp-qt5(x86-64) qxmpp-qt5-devel: cmake(QXmpp) cmake(QXmppOmemoQt5) cmake(QXmppQt5) cmake(qxmpp) cmake(qxmppomemoqt5) cmake(qxmppqt5) pkgconfig(QXmppQt5) pkgconfig(qxmpp) qxmpp-qt5-devel qxmpp-qt5-devel(x86-64) qxmpp-qt6: libQXmppOmemoQt6.so.4()(64bit) libQXmppQt6.so.4()(64bit) qxmpp-qt6 qxmpp-qt6(x86-64) qxmpp-qt6-devel: cmake(QXmpp) cmake(QXmppOmemoQt6) cmake(QXmppQt6) cmake(qxmpp) cmake(qxmppomemoqt6) cmake(qxmppqt6) pkgconfig(QXmppQt6) pkgconfig(qxmpp) qxmpp-qt6-devel qxmpp-qt6-devel(x86-64) qxmpp-doc: qxmpp-doc qxmpp-debuginfo: qxmpp-debuginfo qxmpp-debuginfo(x86-64) qxmpp-debugsource: qxmpp-debugsource qxmpp-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -B -r -n qxmpp-1.5.5-1.fc39.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, Haskell, fonts, R, Ocaml, Perl, SugarActivity, PHP, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Issues: 1) The License field must only carry the expression of licenses for the content used to create the binary packages. The expression should be: LGPL-2.1-or-later AND CC0-1.0 AND CC-BY-SA-4.0 The MIT-Modern-Variant for the files in cmake/modules/ should not be listed because those files are not part of the binary packages. Nor should the GPL-3.0-only identifier be listed because that is a linked dependency and not part of this package. For more information: https://docs.fedoraproject.org/en-US/legal/license-field/ https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis 2) The qt5 and qt6 subpackages lack an explicit versioned requires on the main package: Requires: %{name}%{?_isa} = %{version}-%{release}
1): Thanks for the clarification of license issue. fixed. 2): adding to `Requires: %{name}%{?_isa} = %{version}-%{release}` to qt5 and qt6 sub-packages will not work when installing the packages, because there is no file to create the qxmpp package, which will be required if adding this line. So I do not add the line. Spec URL: https://topazus.fedorapeople.org/rpms/qxmpp.spec SRPM URL: https://topazus.fedorapeople.org/rpms/qxmpp-1.5.5-1.fc39.src.rpm
(In reply to Felix Wang from comment #7) > 1): Thanks for the clarification of license issue. fixed. Thanks. > 2): adding to `Requires: %{name}%{?_isa} = %{version}-%{release}` to qt5 and > qt6 sub-packages will not work when installing the packages, because there > is no file to create the qxmpp package, which will be required if adding > this line. So I do not add the line. Oh yeah, my mistake. I didn't look closely enough at the built RPMs. Everything looks good now.
Many Thanks, close as the completion of qxmpp package unretirement. https://pagure.io/releng/issue/11493