Bug 2214428 - Review Request: rust-tower-http - Tower middleware and utilities for HTTP clients and servers
Summary: Review Request: rust-tower-http - Tower middleware and utilities for HTTP cli...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/tower-http
Whiteboard:
Depends On: 2214392 2214394 2214427
Blocks: 2214429
TreeView+ depends on / blocked
 
Reported: 2023-06-13 00:40 UTC by Fabio Valentini
Modified: 2023-07-27 16:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-27 16:17:46 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-06-13 00:40:57 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-tower-http.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-tower-http-0.4.0-1.fc38.src.rpm

Description:
Tower middleware and utilities for HTTP clients and servers.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-13 00:42:12 UTC
COPR build:
https://copr.fedorainfracloud.org/coprs/decathorpe/ntpd-rs/build/6069552/

Comment 2 Michel Lind 2023-07-27 02:56:20 UTC
Subpackages fail to install due to missing crate async-compression 0.3 -- looks like it's been bumped to 0.4.1

https://koji.fedoraproject.org/koji/packageinfo?packageID=31339

 Problem 1: conflicting requests
  - nothing provides (crate(async-compression/default) >= 0.3.0 with crate(async-compression/default) < 0.4.0~) needed by rust-tower-http+async-compression-devel-0.4.0-1.fc39.noarch from @commandline
  - nothing provides (crate(async-compression/tokio) >= 0.3.0 with crate(async-compression/tokio) < 0.4.0~) needed by rust-tower-http+async-compression-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 2: conflicting requests
  - nothing provides (crate(async-compression/brotli) >= 0.3.0 with crate(async-compression/brotli) < 0.4.0~) needed by rust-tower-http+compression-br-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 3: conflicting requests
  - nothing provides (crate(async-compression/zlib) >= 0.3.0 with crate(async-compression/zlib) < 0.4.0~) needed by rust-tower-http+compression-deflate-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 4: conflicting requests
  - nothing provides (crate(async-compression/gzip) >= 0.3.0 with crate(async-compression/gzip) < 0.4.0~) needed by rust-tower-http+compression-gzip-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 5: conflicting requests
  - nothing provides (crate(async-compression/zstd) >= 0.3.0 with crate(async-compression/zstd) < 0.4.0~) needed by rust-tower-http+compression-zstd-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 6: conflicting requests
  - nothing provides (crate(async-compression/brotli) >= 0.3.0 with crate(async-compression/brotli) < 0.4.0~) needed by rust-tower-http+decompression-br-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 7: conflicting requests
  - nothing provides (crate(async-compression/zlib) >= 0.3.0 with crate(async-compression/zlib) < 0.4.0~) needed by rust-tower-http+decompression-deflate-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 8: conflicting requests
  - nothing provides (crate(async-compression/gzip) >= 0.3.0 with crate(async-compression/gzip) < 0.4.0~) needed by rust-tower-http+decompression-gzip-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 9: conflicting requests
  - nothing provides (crate(async-compression/zstd) >= 0.3.0 with crate(async-compression/zstd) < 0.4.0~) needed by rust-tower-http+decompression-zstd-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 10: package rust-tower-http+decompression-full-devel-0.4.0-1.fc39.noarch from @commandline requires crate(tower-http/decompression-zstd) = 0.4.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(async-compression/zstd) >= 0.3.0 with crate(async-compression/zstd) < 0.4.0~) needed by rust-tower-http+decompression-zstd-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 11: package rust-tower-http+compression-full-devel-0.4.0-1.fc39.noarch from @commandline requires crate(tower-http/compression-zstd) = 0.4.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(async-compression/zstd) >= 0.3.0 with crate(async-compression/zstd) < 0.4.0~) needed by rust-tower-http+compression-zstd-devel-0.4.0-1.fc39.noarch from @commandline
 Problem 12: package rust-tower-http+full-devel-0.4.0-1.fc39.noarch from @commandline requires crate(tower-http/compression-full) = 0.4.0, but none of the providers can be installed
  - package rust-tower-http+compression-full-devel-0.4.0-1.fc39.noarch from @commandline requires crate(tower-http/compression-zstd) = 0.4.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(async-compression/zstd) >= 0.3.0 with crate(async-compression/zstd) < 0.4.0~) needed by rust-tower-http+compression-zstd-devel-0.4.0-1.fc39.noarch from @commandline
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
WARNING: Failed install built packages

Comment 3 Fabio Valentini 2023-07-27 09:28:55 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-tower-http.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-tower-http-0.4.3-1.fc38.src.rpm

Updated to the latest version, dropped the patch that's no longer necessary.
This version also depends on async-compression 0.4, so the installability issue is solved as well.

Comment 4 Fedora Review Service 2023-07-27 09:46:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6216591
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2214428-rust-tower-http/fedora-rawhide-x86_64/06216591-rust-tower-http/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Michel Lind 2023-07-27 15:44:54 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 6 Fedora Admin user for bugzilla script actions 2023-07-27 15:47:16 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tower-http

Comment 7 Fabio Valentini 2023-07-27 16:17:46 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3e6677ff44


Note You need to log in before you can comment on or make changes to this bug.