Spec URL: https://smani.fedorapeople.org/review/gtksourceviewmm3.spec SRPM URL: https://smani.fedorapeople.org/review/gtksourceviewmm3-3.21.3-1.fc39.src.rpm Description: A C++ wrapper for gtksourceview3 Fedora Account System Username: smani Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=102166406 This is a review to revive the retired package.
Take this, will review it later.
Would you mind taking the package review for exchange? https://bugzilla.redhat.com/show_bug.cgi?id=2214308
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/gtksourceviewmm3 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "FSF All Permissive License", "FSF Unlimited License (with License Retention) GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License v3.0 or later", "X11 License [generated file]", "FSF Unlimited License (with License Retention) GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Mass Ave)]", "*No copyright* GNU Library General Public License v2 or later", "MIT License". 261 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/gtksourceviewmm3/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gtksourceviewmm3-3.21.3-1.fc39.x86_64.rpm gtksourceviewmm3-devel-3.21.3-1.fc39.x86_64.rpm gtksourceviewmm3-doc-3.21.3-1.fc39.noarch.rpm gtksourceviewmm3-debuginfo-3.21.3-1.fc39.x86_64.rpm gtksourceviewmm3-debugsource-3.21.3-1.fc39.x86_64.rpm gtksourceviewmm3-3.21.3-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp4w7exqq')] checks: 31, packages: 6 gtksourceviewmm3-devel.x86_64: W: no-documentation gtksourceviewmm3.x86_64: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3/COPYING gtksourceviewmm3-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3-doc/COPYING 6 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: gtksourceviewmm3-debuginfo-3.21.3-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpovp9h147')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libgdk-3.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libz.so.1 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libharfbuzz.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libpango-1.0.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libpangocairo-1.0.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libatk-1.0.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libcairo-gobject.so.2 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libgio-2.0.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libgdk_pixbuf-2.0.so.0 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libcairo.so.2 gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libm.so.6 gtksourceviewmm3-devel.x86_64: W: no-documentation gtksourceviewmm3-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3-doc/COPYING gtksourceviewmm3.x86_64: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3/COPYING 5 packages and 0 specfiles checked; 13 errors, 1 warnings, 13 badness; has taken 0.5 s Source checksums ---------------- http://ftp.gnome.org/pub/GNOME/sources/gtksourceviewmm/3.21/gtksourceviewmm-3.21.3.tar.xz : CHECKSUM(SHA256) this package : dbb00b1c28e0407cc27d8b07a2ed0b4ea22f92e4b3e3006431cbd6726b6256b5 CHECKSUM(SHA256) upstream package : dbb00b1c28e0407cc27d8b07a2ed0b4ea22f92e4b3e3006431cbd6726b6256b5 Requires -------- gtksourceviewmm3 (rpmlib, GLIBC filtered): glibmm24(x86-64) gtkmm30(x86-64) gtksourceview3(x86-64) libatk-1.0.so.0()(64bit) libatkmm-1.6.so.1()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcairomm-1.0.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgdkmm-3.0.so.1()(64bit) libgio-2.0.so.0()(64bit) libgiomm-2.4.so.1()(64bit) libglib-2.0.so.0()(64bit) libglibmm-2.4.so.1()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtkmm-3.0.so.1()(64bit) libgtksourceview-3.0.so.1()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangomm-1.4.so.1()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gtksourceviewmm3-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gtksourceviewmm3(x86-64) libgtksourceviewmm-3.0.so.0()(64bit) pkgconfig(glibmm-2.4) pkgconfig(gtkmm-3.0) pkgconfig(gtksourceview-3.0) gtksourceviewmm3-doc (rpmlib, GLIBC filtered): gtkmm30-doc gtksourceviewmm3-debuginfo (rpmlib, GLIBC filtered): gtksourceviewmm3-debugsource (rpmlib, GLIBC filtered): Provides -------- gtksourceviewmm3: gtksourceviewmm3 gtksourceviewmm3(x86-64) libgtksourceviewmm-3.0.so.0()(64bit) gtksourceviewmm3-devel: gtksourceviewmm3-devel gtksourceviewmm3-devel(x86-64) pkgconfig(gtksourceviewmm-3.0) gtksourceviewmm3-doc: gtksourceviewmm3-doc gtksourceviewmm3-debuginfo: debuginfo(build-id) gtksourceviewmm3-debuginfo gtksourceviewmm3-debuginfo(x86-64) libgtksourceviewmm-3.0.so.0.0.0-3.21.3-1.fc39.x86_64.debug()(64bit) gtksourceviewmm3-debugsource: gtksourceviewmm3-debugsource gtksourceviewmm3-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gtksourceviewmm3 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, Java, Ocaml, fonts, SugarActivity, Python, R, Haskell, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH --- 1) > gtksourceviewmm3.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libgtksourceviewmm-3.0.so.0.0.0 /lib64/libgdk-3.so.0 The unused-direct-shlib-dependency issue could be solved by adding --as-needed flag? ref: https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency 2) > gtksourceviewmm3-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3-doc/COPYING > gtksourceviewmm3.x86_64: E: incorrect-fsf-address /usr/share/licenses/gtksourceviewmm3/COPYING The incorrect-fsf-address warning may be good to report to the upstream. ref: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address 3) > License: LGPLv2+ License is proposed and proper to use SPDX format license. ref: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
Spec URL: https://smani.fedorapeople.org/review/gtksourceviewmm3.spec SRPM URL: https://smani.fedorapeople.org/review/gtksourceviewmm3-3.21.3-2.fc39.src.rpm %changelog * Fri Jun 16 2023 Sandro Mani <manisandro> - 3.21.3-2 - Use SPDX license identifier -- 1) -Wl,--as-needed is actually present in the LDFLAGS, not sure how to avoid the unused-direct-shlib-dependency 2) Fear the upstream project is pretty stale 3) Fixed
Ok, thanks for the response. I am also not clear with unused-direct-shlib-dependency, which may be the only issue. Since this is a review for retired package, approved for now.
Thanks! Filed unretirement request https://pagure.io/releng/issue/11487