Bug 2215517 - Review Request: lumin - Highlight matches in files [NEEDINFO]
Summary: Review Request: lumin - Highlight matches in files
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2024395
TreeView+ depends on / blocked
 
Reported: 2023-06-16 09:41 UTC by Stephen Kitt
Modified: 2025-06-05 16:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
michel: fedora-review+
michel: needinfo? (steve)


Attachments (Terms of Use)

Description Stephen Kitt 2023-06-16 09:41:56 UTC
Spec URL: https://sk2.org/lumin.spec
SRPM URL: https://sk2.org/lumin-1.0.0-1.fc39.src.rpm
Description: Simple command-line tool to highlight matches in files -- like grep with --color, but shows all lines while highlighting matches.
Fedora Account System Username: skitt

This is a build-dependency for Miller (mlr).

Comment 1 Package Review 2025-05-08 00:45:22 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 2 Michel Lind 2025-05-08 16:53:28 UTC
I guess this is not really needed anymore since miller 6 is rewritten? Sorry for letting it languish so long - clearing it in case someone else needs this package and wants to review it

Comment 3 Stephen Kitt 2025-05-08 18:01:08 UTC
@michel it’s one of Miller 6’s dependencies, I packaged it in preparation for Miller 6 way back when. (It’s vendored in the Miller 6 package, so perhaps this is no longer useful.)

Comment 4 Michel Lind 2025-05-13 15:24:25 UTC
Ah yes. And it ships CLI binaries so it is probably useful as a standalone binary anyway. I'll try to get to it this week.

Comment 5 Michel Lind 2025-06-05 16:43:43 UTC
Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the software is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Golang Packaging Guidelines

Package APPROVED.

===

Recommended post-import go-sig tasks (use `fedora-sig-onboard onboard $goname`:

- add @go-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @go-sig (optional)

- track package in koschei for all built branches


Note You need to log in before you can comment on or make changes to this bug.