Spec URL: https://sk2.org/lumin.spec SRPM URL: https://sk2.org/lumin-1.0.0-1.fc39.src.rpm Description: Simple command-line tool to highlight matches in files -- like grep with --color, but shows all lines while highlighting matches. Fedora Account System Username: skitt This is a build-dependency for Miller (mlr).
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
I guess this is not really needed anymore since miller 6 is rewritten? Sorry for letting it languish so long - clearing it in case someone else needs this package and wants to review it
@michel it’s one of Miller 6’s dependencies, I packaged it in preparation for Miller 6 way back when. (It’s vendored in the Miller 6 package, so perhaps this is no longer useful.)
Ah yes. And it ships CLI binaries so it is probably useful as a standalone binary anyway. I'll try to get to it this week.
Package was generated with go2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the software is packaged - license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora - license file is included with %license in %files - package complies with Golang Packaging Guidelines Package APPROVED. === Recommended post-import go-sig tasks (use `fedora-sig-onboard onboard $goname`: - add @go-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @go-sig (optional) - track package in koschei for all built branches
@michel apologies, I let this lapse — could you re-approve the package?
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9819257 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2215517-lumin/fedora-rawhide-x86_64/09819257-lumin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
Sorry, it's been busy on my end too. reapproved
The Pagure repository was created at https://src.fedoraproject.org/rpms/lumin