Spec URL: https://github.com/martintc/fedora-packages-wip/blob/main/blogc/blogc.spec SRPM URL: https://github.com/martintc/fedora-packages-wip/blob/main/blogc/blogc-0.20.1-1.fc38.src.rpm Description: A blog simple make file based log compiler written in c. Fedora Account System Username: martintc Copr builds: https://copr.fedorainfracloud.org/coprs/martintc/blogc/build/6058855/
Use Raw if on GitHub Spec URL: https://raw.githubusercontent.com/martintc/fedora-packages-wip/main/blogc/blogc.spec Alternatively, copr is fine: Spec URL: https://download.copr.fedorainfracloud.org/results/martintc/blogc/fedora-38-x86_64/06058855-blogc/blogc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/martintc/blogc/fedora-38-x86_64/06058855-blogc/blogc-0.20.1-1.fc38.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "[generated file]", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "X11 License [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License", "FSF Unlimited License (with License Retention) GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)", "MIT License". 141 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/blogc/2216074-blogc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: blogc-0.20.1-1.fc39.x86_64.rpm blogc-debuginfo-0.20.1-1.fc39.x86_64.rpm blogc-debugsource-0.20.1-1.fc39.x86_64.rpm blogc-0.20.1-1.fc39.src.rpm ======================================================= rpmlint session starts ======================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2scbjltz')] checks: 31, packages: 4 blogc.src: W: summary-ended-with-dot A blog compiler. blogc.x86_64: W: summary-ended-with-dot A blog compiler. blogc.src: E: description-line-too-long Blogc is a static site generator written mostly in C using makefiles to build the website. blogc.x86_64: E: description-line-too-long Blogc is a static site generator written mostly in C using makefiles to build the website. ======================== 4 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 3.2 s ======================== Rpmlint (debuginfo) ------------------- Checking: blogc-debuginfo-0.20.1-1.fc39.x86_64.rpm ======================================================= rpmlint session starts ======================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmhgl90xw')] checks: 31, packages: 1 ======================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.3 s ======================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 blogc.x86_64: W: summary-ended-with-dot A blog compiler. blogc.x86_64: E: description-line-too-long Blogc is a static site generator written mostly in C using makefiles to build the website. 3 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 3.2 s Source checksums ---------------- https://github.com/blogc/blogc/releases/download/v0.20.1/blogc-0.20.1.tar.gz : CHECKSUM(SHA256) this package : 2ebc929d014bae02fe44377a9b3988f7a3b8259ef579e13daf027f52d9aaf319 CHECKSUM(SHA256) upstream package : 2ebc929d014bae02fe44377a9b3988f7a3b8259ef579e13daf027f52d9aaf319 Requires -------- blogc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) blogc-debuginfo (rpmlib, GLIBC filtered): blogc-debugsource (rpmlib, GLIBC filtered): Provides -------- blogc: blogc blogc(x86-64) blogc-debuginfo: blogc-debuginfo blogc-debuginfo(x86-64) debuginfo(build-id) blogc-debugsource: blogc-debugsource blogc-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2216074 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: R, Java, Ocaml, fonts, Ruby, Perl, Haskell, PHP, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Thanks for packaging this. You will need to become a packager. See: https://docs.fedoraproject.org/en-US/fesco/Packager_sponsor_policy/#requesting_sponsorship Am not a sponsor, so you will need to find a sponsor b) Builds on all required architectures: https://copr.fedorainfracloud.org/coprs/martintc/blogc/build/6058855/ c) blogc-0.20.1/src/common/utf8.c is under MIT license. Please indicate this in the spec file and add a license breakdown, see: https://docs.fedoraproject.org/en-US/legal/license-field/ d) Please update changelog entry appropriately e) Package is signed: https://github.com/blogc/blogc/releases/tag/v0.20.1 Please verify the signature, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification f) Please enable tests, cmocka and probably valgrind are needed as a build dependency: https://packages.fedoraproject.org/pkgs/cmocka/ then add `make check` in the %check section of the spec file g) Would be good to build manuals from source. Please add ronn as a build dependency: https://packages.fedoraproject.org/pkgs/rubygem-ronn-ng/rubygem-ronn-ng/ This will also generate man 5 files h) Other warnings from fedora-review: blogc.x86_64: W: summary-ended-with-dot A blog compiler. blogc.x86_64: E: description-line-too-long Blogc is a static site generator written mostly in C using makefiles to build the website.