Red Hat Bugzilla – Bug 221665
Review Request: php-pear-Numbers-Roman - Provides methods for converting to and from Roman Numerals
Last modified: 2007-11-30 17:11:52 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Numbers-Roman.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Numbers-Roman-1.0.1-1.src.rpm
Numbers_Roman provides static methods for converting to and from Roman
numerals. It supports Roman numerals in both uppercase and lowercase
styles and conversion for and to numbers up to 5 999 999.
OK - package meets naming and packaging guidelines.
OK - specfile is properly named, is cleanly written and uses macros consistently.
OK - dist tag is present.
OK - build root is correct.
OK - license field matches the actual license.
OK - license is open source-compatible.
ok - source files match upstream:
OK - latest version is being packaged.
OK - BuildRequires are proper.
OK - package builds in mock
OK - rpmlint is silent.
OK - final provides and requires are sane:
OK - no shared libraries are present.
OK - package is not relocatable.
OK - owns the directories it creates.
OK - doesn't own any directories it shouldn't.
OK - no duplicates in %files.
OK - file permissions are appropriate.
OK - %clean is present.
OK - %check is not present, no tests included by upstream
OK - pear scriptlets are standard
OK - code, not content.
OK - documentation is small, so no -docs subpackage is necessary.
OK - no headers.
OK - no pkgconfig files.
OK - no libtool .la droppings.
OK - not a GUI app.
Cut-and-dry pear package. APPROVED.
- imported in cvs
- added entry to owners.list
- tagged and built for devel
- requested cvs sync for FC5/6
THANKS FOR THE REVIEW!
Package Change Request
Package Name: php-pear-Numbers-Roman
New Branches: EL-5