Red Hat Bugzilla – Bug 221670
Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent
Last modified: 2007-11-30 17:11:52 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect-2.2.0-1.src.rpm
The Net_UserAgent object does a number of tests on an HTTP user
agent string. The results of these tests are available via methods of
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (PHP)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
See below - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
OK(i386/x86_64) - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
1. According to the comments in the source file the license of
this package is the php 2.0 license, available as:
The PHP-LICENSE-3.01 included seems to be a newer, diffrent version.
2. This package owns the
/usr/share/pear/Net directory. Should it? Or should it require some
other package that does?
* Sat Jan 13 2007 Christopher Stone <email@example.com> 2.2.0-2
- Use PHP License version 2.02
> 2. This package owns the
> /usr/share/pear/Net directory. Should it? Or should it require some
> other package that does?
There are many pear packages that share ownership of the same directories. The
general rule of thumb in this case is that if the owner of a directory is
unclear then the package should own the directory.
1. Ok, looks good now.
2. Fair enough, just wanted to make sure you were aware of the issue.
I see no further blockers here, so this package is APPROVED.
Don't forget to close this review request NEXTRELEASE once it's been
imported and built.
- imported into cvs
- updated owners.list
- tagged and built for devel
- cvs sync requested for fc5/6
THANKS FOR THE REVIEW!
Package Change Request
Package Name: php-pear-Net-UserAgent-Detect
New Branches: EL-5