SPEC: https://pbrobinson.fedorapeople.org/liblc3.spec SRPM: https://pbrobinson.fedorapeople.org/liblc3-1.0.3-1.fc38.src.rpm Description: The Low Complexity Communication Codec (LC3) is used by Bluetooth as the codec for LE Audio. It enables high quality audio over the low bandwidth connections provided by Bluetooth LE. FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102450846
1) > %ldconfig_scriptlets No need to add this ldconfig scriptlets, see: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets 2) > %{_bindir}/dlc3 > %{_bindir}/elc3 I think the CLI tools will be more proper to put them in -devel sub-package, or put them in a new sub-package named -tools. 3) It seems no tests running on %check build section. --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 4 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/liblc3/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: liblc3-1.0.3-1.fc38.x86_64.rpm liblc3-devel-1.0.3-1.fc38.x86_64.rpm liblc3-debuginfo-1.0.3-1.fc38.x86_64.rpm liblc3-debugsource-1.0.3-1.fc38.x86_64.rpm liblc3-1.0.3-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps5ekogq9')] checks: 31, packages: 5 liblc3.x86_64: W: no-manual-page-for-binary dlc3 liblc3.x86_64: W: no-manual-page-for-binary elc3 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: liblc3-debuginfo-1.0.3-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7j5rbhti')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 liblc3.x86_64: W: no-manual-page-for-binary dlc3 liblc3.x86_64: W: no-manual-page-for-binary elc3 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://github.com/google/liblc3/archive/v1.0.3/liblc3-1.0.3.tar.gz : CHECKSUM(SHA256) this package : 33318036a4b83af697b328e55e8c5fab9763836083bccb586f4dc2e644c24991 CHECKSUM(SHA256) upstream package : 33318036a4b83af697b328e55e8c5fab9763836083bccb586f4dc2e644c24991 Requires -------- liblc3 (rpmlib, GLIBC filtered): libc.so.6()(64bit) liblc3.so.1()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) liblc3-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config liblc3(x86-64) liblc3.so.1()(64bit) liblc3-debuginfo (rpmlib, GLIBC filtered): liblc3-debugsource (rpmlib, GLIBC filtered): Provides -------- liblc3: liblc3 liblc3(x86-64) liblc3.so.1()(64bit) liblc3-devel: liblc3-devel liblc3-devel(x86-64) pkgconfig(lc3) liblc3-debuginfo: debuginfo(build-id) liblc3-debuginfo liblc3-debuginfo(x86-64) liblc3.so.1-1.0.3-1.fc38.x86_64.debug()(64bit) liblc3-debugsource: liblc3-debugsource liblc3-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name liblc3 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, Haskell, fonts, Perl, PHP, SugarActivity, Python, R, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Could you take my package review of Kaidan for exchange? https://bugzilla.redhat.com/show_bug.cgi?id=2216600
> No need to add this ldconfig scriptlets, see: > https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets I had thought that was moving to the macro, but removed. > I think the CLI tools will be more proper to put them in -devel sub-package, > or put them in a new sub-package named -tools. I put them in a utils sub package, they don't fit in devel, I had left them there simply because they were just 40kb. > It seems no tests running on %check build section. Well that's upstream, but if/when upstream adds tests it means they will automatically run. I don't see this as an issue as it's not a requirement for tests. SPEC: https://pbrobinson.fedorapeople.org/liblc3.spec SRPM: https://pbrobinson.fedorapeople.org/liblc3-1.0.4-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104341501
Copr build: https://copr.fedorainfracloud.org/coprs/build/6240288 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216743-liblc3/fedora-rawhide-x86_64/06240288-liblc3/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Felix can you finish the review please?
> BuildRequires: make What's using make? AFAIK, Meson uses ninja-build, right?
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
Taking this review.
> %{_libdir}/liblc3.so.1* Could you adjust this glob to "%{_libdir}/liblc3.so.1{,.*}"? That way it won't match on "liblc3.so.10" or similar.
At this point, the two issues I see here are ones I noted in comment 6 and comment 9. Please address those and I will be able to approve the review.
Updated: SPEC: https://pbrobinson.fedorapeople.org/liblc3.spec SRPM: https://pbrobinson.fedorapeople.org/liblc3-1.0.4-2.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=108970044
Created attachment 1999146 [details] The .spec file difference from Copr build 6240288 to 6630299
Copr build: https://copr.fedorainfracloud.org/coprs/build/6630299 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216743-liblc3/fedora-rawhide-x86_64/06630299-liblc3/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/liblc3