Bug 2216848 - salt-minion pkg.* tasks fail if only dnf5 is present, not dnf
Summary: salt-minion pkg.* tasks fail if only dnf5 is present, not dnf
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: salt
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Kirill Ponomarev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-22 20:03 UTC by Gwyn Ciesla
Modified: 2023-07-24 18:03 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-24 17:34:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github saltstack salt issues 64532 0 None open salt-minion pkg.* tasks fail if only dnf5 is present, not dnf 2023-06-22 20:04:13 UTC

Description Gwyn Ciesla 2023-06-22 20:03:59 UTC
Starting with Fedora 39, dnf is obsoleted by dnf5. The command line options are different, so a simple symlink won't work.

      ID: install_fedora_packages
Function: pkg.installed
  Result: False
 Comment: Error occurred installing package(s). Additional info follows:
          
          errors:
              - Unknown argument "--allowerasing" for command "dnf5". Add "--help" for more information about the arguments.
 Started: 19:45:43.710036
Duration: 1480.451 ms
 Changes:   

Reproducible: Always

Comment 1 Jaroslav Mracek 2023-06-23 07:29:43 UTC
Thank you very much for the report. The option `--allowerasing` is implemented, but it is defined under command not as general option.

`dnf5 install --allowerasing acpi` works but `dnf5 --allowerasing install acpi` does not.

The change is driven by not allowing options for command where they have no effect (dnf repoquery --allowerasing).

Do you have any suggestion what would be the best place how to document the change? My suggestion would be to document the change in https://dnf5.readthedocs.io/en/latest/changes.html.

Comment 2 Gwyn Ciesla 2023-06-23 14:40:57 UTC
That makes sense to me.

Comment 3 David Murphy 2023-06-26 20:25:40 UTC
Have a Salt issue addressing this https://github.com/saltstack/salt/issues/64532

Comment 4 David Murphy 2023-07-24 17:59:25 UTC
Fix for https://github.com/saltstack/salt/issues/64532 merged into the Salt master branch

Comment 5 Gwyn Ciesla 2023-07-24 18:03:09 UTC
Thank you!


Note You need to log in before you can comment on or make changes to this bug.