Bug 2217044 - Review Request: rust-sval_serde - Integration between serde::Serialize and sval::Value
Summary: Review Request: rust-sval_serde - Integration between serde::Serialize and sv...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2217034 2217037
Blocks: 2217056
TreeView+ depends on / blocked
 
Reported: 2023-06-23 16:59 UTC by Fabio Valentini
Modified: 2023-07-18 22:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-18 22:49:12 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-06-23 16:59:02 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-sval_serde.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sval_serde-2.6.0-1.fc38.src.rpm

Description:
Integration between serde::Serialize and sval::Value.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-23 17:00:36 UTC
This depends on: https://bugzilla.redhat.com/show_bug.cgi?id=2181433
But builds can only be pushed together with all sval 2.6.0 / value-bag 1.4.0 updates to avoid broken dependencies and / or creating unnecessary compat packages.
A COPR build is available here: https://copr.fedorainfracloud.org/coprs/decathorpe/log-0.4.19-sval-v2/build/6108413/

Comment 3 Michel Lind 2023-07-18 22:30:28 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fabio Valentini 2023-07-18 22:34:58 UTC
Thanks for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-18 22:35:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sval_serde

Comment 6 Fabio Valentini 2023-07-18 22:49:12 UTC
Imported and built in f39-build-side-69808:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2234670


Note You need to log in before you can comment on or make changes to this bug.