Spec URL: https://fedorapeople.org/~chkr/review/lua-ldap.spec SRPM URL: https://fedorapeople.org/~chkr/review/lua-ldap-1.3.1-1.fc36.src.rpm Description: LuaLDAP is a simple interface from Lua to an LDAP client. It enables a Lua program to: * Connect to an LDAP server * Execute any operation (search, add, compare, delete, modify and rename) * Retrieve entries and references of the search result Note: this is a re-review in order to unretire lua-ldap Fedora Account System Username: chkr
I am sorry for being slow. These are my thoughts while reading the spec file: You can avoid "%global luaver 5.4" by using the more modern "%{lua_version}" instead. See also: https://fedoraproject.org/wiki/PackagingDrafts/Lua You can avoid "%global lualibdir %{_libdir}/lua/%{luaver}" by using the more modern "%{lua_libdir}" instead. See also: https://fedoraproject.org/wiki/PackagingDrafts/Lua As "%{luapkgdir}" isn't used, you could simply remove "%global luapkgdir %{_datadir}/lua/%{luaver}". You could use "https://github.com/lualdap/lualdap/archive/v%{version}/lualdap-%{version}.tar.gz" instead of "https://github.com/lualdap/lualdap/archive/refs/tags/v1.3.1.tar.gz", which creates a more nice tarball name and doesn't hardcode the version. See also: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ I would recommend "BuildRequires: lua-devel >= %{lua_version}" instead of only "BuildRequires: lua-devel". You should add "BuildRequires: make" when using "make" in "%build" etc. In Fedora, "make" is no longer part of the default buildroot, see also: https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot Using "%make_build" instead of "make %{?_smp_mflags}" is recommented. See also: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make Using "%make_install" instead of "make install DESTDIR=%{buildroot}" is recommented. See also https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_the_makeinstall_macro_should_not_be_used Rather than changing the 'config' file during "%setup", you could also simply append 'CFLAGS="%{optflags}" LDFLAGS="%{?__global_ldflags} -fPIC" LUA_LIBDIR=%{_libdir} LUA_INCDIR=%{_includedir}' to "%make_build" (note I that I used "%{optflags}" instead of "$RPM_OPT_FLAGS", because you used the macro style instead of environment variables at other places, too). And appending 'INST_LIBDIR=%{lua_libdir}' to "%make_install" might ease things as well. See also: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags While it is not necessary, a "%check" section could help to ensure that the Lua module can be actually loaded by the Lua interpreter (sometimes Lua modules break during a Lua update and isn't catched by a simple rebuild, but during run-time). My suggestion here is: --- 8< --- %check lua -e \ 'package.cpath="%{buildroot}%{lua_libdir}/?.so;"..package.cpath; local lualdap = require("lualdap"); print("Hello from "..lualdap._VERSION.."!");' --- 8< --- However, this requires additionally (and latter only if you target RHEL < 9): --- 8< --- BuildRequires: lua >= %{lua_version} %if 0%{?rhel} && 0%{?rhel} < 9 Requires: lua(abi) = %{lua_version} %endif --- 8< --- And if you target RHEL 7 as well, you need also this: --- 8< --- %if 0%{?rhel} == 7 BuildRequires: lua-rpm-macros %endif --- 8< --- You could add "%license docs/license.md" to "%files". I would tune "%docs" to "%doc README.md docs/[cmn]*.md" to avoid picking up the logo (which is unused/unreferenced inside the docs), while the "index.md" is more or less similar to "README.md". Just let me know if you have any questions.
Thank you very much for the review and the recommendations - the spec file is now much cleaner. Spec URL: https://fedorapeople.org/~chkr/review/lua-ldap.spec SRPM URL: https://fedorapeople.org/~chkr/review/lua-ldap-1.3.1-2.fc36.src.rpm I target EPEL beginning with RHEL 7 as well. I verified, that the latest version of the srpm can be built via mock for the following targets: /etc/mock/centos+epel-7-x86_64.cfg /etc/mock/centos-stream-8-x86_64.cfg /etc/mock/centos-stream-9-x86_64.cfg /etc/mock/fedora-rawhide-x86_64.cfg and on my F37 installation.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6239064 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2217273-lua-ldap/fedora-rawhide-x86_64/06239064-lua-ldap/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. -> Unversioned .so file on non-ld path is fine for Lua module. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Public domain MIT (old)". 47 files have unknown license. -> "Public domain MIT (old)" is only applicable to docs/logo/*, which is not part of the RPM package [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). -> According to %check, the Lua module can be loaded and run properly. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: lua-ldap-1.3.1-2.fc38.x86_64.rpm lua-ldap-debuginfo-1.3.1-2.fc38.x86_64.rpm lua-ldap-debugsource-1.3.1-2.fc38.x86_64.rpm lua-ldap-1.3.1-2.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptk2tuufx')] checks: 31, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (debuginfo) ------------------- Checking: lua-ldap-debuginfo-1.3.1-2.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp925ggjl4')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_gettop (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_settop (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_toboolean (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_touserdata (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_setfuncs (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_argerror (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushcclosure (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_next (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_tointegerx (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_tolstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_ref (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_createtable (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_newuserdatauv (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_rawset (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_optlstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_optnumber (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_rawgeti (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_setfield (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_isnumber (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_checklstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushvalue (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushfstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_tonumberx (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_rawseti (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_getglobal (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushnumber (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushboolean (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_checkstack (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_checkudata (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushlstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_callk (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_rawlen (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_checkversion_ (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_typename (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_error (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushnil (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_concat (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_setmetatable (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_type (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_newmetatable (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so luaL_unref (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_pushstring (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_getfield (/usr/lib64/lua/5.4/lualdap.so) lua-ldap.x86_64: W: undefined-non-weak-symbol /usr/lib64/lua/5.4/lualdap.so lua_isstring (/usr/lib64/lua/5.4/lualdap.so) 3 packages and 0 specfiles checked; 0 errors, 44 warnings, 0 badness; has taken 0.2 s Unversioned so-files -------------------- lua-ldap: /usr/lib64/lua/5.4/lualdap.so Source checksums ---------------- https://github.com/lualdap/lualdap/archive/v1.3.1/lualdap-1.3.1.tar.gz : CHECKSUM(SHA256) this package : c69873cfd7fb50ce22dfcfe50e2023a640a36b3f7b135f2318cb2720d122cac2 CHECKSUM(SHA256) upstream package : c69873cfd7fb50ce22dfcfe50e2023a640a36b3f7b135f2318cb2720d122cac2 Requires -------- lua-ldap (rpmlib, GLIBC filtered): libc.so.6()(64bit) liblber.so.2()(64bit) liblber.so.2(OPENLDAP_2.200)(64bit) libldap.so.2()(64bit) libldap.so.2(OPENLDAP_2.200)(64bit) lua(abi) rtld(GNU_HASH) lua-ldap-debuginfo (rpmlib, GLIBC filtered): lua-ldap-debugsource (rpmlib, GLIBC filtered): Provides -------- lua-ldap: lua-ldap lua-ldap(x86-64) lua-ldap-debuginfo: debuginfo(build-id) lua-ldap-debuginfo lua-ldap-debuginfo(x86-64) lua-ldap-debugsource: lua-ldap-debugsource lua-ldap-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name lua-ldap --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, fonts, Ocaml, Python, SugarActivity, Haskell, R, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- -> Package looks fine to me, APPROVED.
FEDORA-2023-fb09971da5 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fb09971da5
FEDORA-2023-9978fba777 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9978fba777
FEDORA-2023-9978fba777 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9978fba777 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9978fba777 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-fb09971da5 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fb09971da5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fb09971da5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-1ac6a6d6ae has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-1ac6a6d6ae
FEDORA-EPEL-2023-1ac6a6d6ae has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-1ac6a6d6ae See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-1ac6a6d6ae has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-9978fba777 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-fb09971da5 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.