Bug 2217730 - Review Request: ocaml-ppx-deriving-yaml - Derive conversion functions between OCaml types and YAML
Summary: Review Request: ocaml-ppx-deriving-yaml - Derive conversion functions between...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/patricoferris/ppx_...
Whiteboard:
Depends On: 2217729
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-27 03:33 UTC by Jerry James
Modified: 2023-07-13 23:04 UTC (History)
2 users (show)

Fixed In Version: ocaml-ppx-deriving-yaml-0.2.1-3.fc39
Clone Of:
Environment:
Last Closed: 2023-07-13 23:04:51 UTC
Type: ---
Embargoed:
rjones: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2023-06-27 03:33:17 UTC
Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving-yaml/ocaml-ppx-deriving-yaml.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving-yaml/ocaml-ppx-deriving-yaml-0.2.1-1.fc39.src.rpm
Fedora Account System Username: jjames
Description: This ppx is based on ppx_yojson [1] and ppx_deriving_yojson [2] because of the many similarities between JSON and yaml.  In particular many of the ways OCaml values are encoded to yaml types are the same as those implemented by the Yojson ppx.

References:
[1] https://github.com/NathanReb/ppx_yojson
[2] https://github.com/ocaml-ppx/ppx_deriving_yojson

Comment 1 Fedora Review Service 2023-06-27 03:36:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6117194
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2217730-ocaml-ppx-deriving-yaml/fedora-rawhide-x86_64/06117194-ocaml-ppx-deriving-yaml/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Richard W.M. Jones 2023-06-27 08:36:53 UTC
As in bug 2217729, would make sense to replace %if 0 with a named
conditional like %if %{run_tests}.

Comment 3 Richard W.M. Jones 2023-06-27 08:50:12 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "ISC License", "*No copyright* ISC
     License [generated file]". 27 files have unknown license. Detailed
     output of licensecheck in /var/tmp/2217730-ocaml-ppx-deriving-
     yaml/licensecheck.txt

The upstream sources are inconsistently annotated, but the intent is
certainly ISC, matching the License field.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.

Uses %dune_build

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ocaml:
[x]: This should never happen

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.

Latest upstream is also 0.2.1.

[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.

Checks are disabled because we don't have all the required packages
in Fedora.

[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ocaml-ppx-deriving-yaml-0.2.1-1.fc38.x86_64.rpm
          ocaml-ppx-deriving-yaml-devel-0.2.1-1.fc38.x86_64.rpm
          ocaml-ppx-deriving-yaml-debuginfo-0.2.1-1.fc38.x86_64.rpm
          ocaml-ppx-deriving-yaml-debugsource-0.2.1-1.fc38.x86_64.rpm
          ocaml-ppx-deriving-yaml-0.2.1-1.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpw3nlm8p9')]
checks: 31, packages: 5

ocaml-ppx-deriving-yaml-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppx_deriving_yaml/ppx_deriving_yaml.a
ocaml-ppx-deriving-yaml.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ppx_deriving_yaml/ppx_deriving_yaml.cmxs

RWMJ: This is fine since these are used by the OCaml compiler.

ocaml-ppx-deriving-yaml-devel.x86_64: W: no-documentation

RWMJ: There is a very little documentation even upstream.

 5 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 0.1 s 




Rpmlint (debuginfo)
-------------------
Checking: ocaml-ppx-deriving-yaml-debuginfo-0.2.1-1.fc38.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpy14a8e7p')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

ocaml-ppx-deriving-yaml-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppx_deriving_yaml/ppx_deriving_yaml.a
ocaml-ppx-deriving-yaml.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/ppx_deriving_yaml/ppx_deriving_yaml.cmxs
ocaml-ppx-deriving-yaml-devel.x86_64: W: no-documentation
 4 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 0.2 s 



Source checksums
----------------
https://github.com/patricoferris/ppx_deriving_yaml/releases/download/v0.2.1/ppx_deriving_yaml-0.2.1.tbz :
  CHECKSUM(SHA256) this package     : def99acbc518eddde3f7a54e43e0f7a18128b73565b3dd45e7579b5d643ff524
  CHECKSUM(SHA256) upstream package : def99acbc518eddde3f7a54e43e0f7a18128b73565b3dd45e7579b5d643ff524


Requires
--------
ocaml-ppx-deriving-yaml (rpmlib, GLIBC filtered):
    ocaml(Astlib)
    ocaml(Astlib__)
    ocaml(Astlib__Ast_402)
    ocaml(Astlib__Ast_403)
    ocaml(Astlib__Ast_404)
    ocaml(Astlib__Ast_405)
    ocaml(Astlib__Ast_406)
    ocaml(Astlib__Ast_407)
    ocaml(Astlib__Ast_408)
    ocaml(Astlib__Ast_409)
    ocaml(Astlib__Ast_410)
    ocaml(Astlib__Ast_411)
    ocaml(Astlib__Ast_412)
    ocaml(Astlib__Ast_413)
    ocaml(Astlib__Ast_414)
    ocaml(Astlib__Ast_500)
    ocaml(Astlib__Location)
    ocaml(Astlib__Longident)
    ocaml(Astlib__Parse)
    ocaml(Asttypes)
    ocaml(Build_path_prefix_map)
    ocaml(CamlinternalFormatBasics)
    ocaml(CamlinternalLazy)
    ocaml(CamlinternalOO)
    ocaml(Clflags)
    ocaml(Cmi_format)
    ocaml(Compmisc)
    ocaml(Env)
    ocaml(Ident)
    ocaml(Identifiable)
    ocaml(Load_path)
    ocaml(Location)
    ocaml(Longident)
    ocaml(Misc)
    ocaml(Ocaml_common)
    ocaml(Ocaml_shadow)
    ocaml(Outcometree)
    ocaml(Parsetree)
    ocaml(Path)
    ocaml(Ppx_deriving_yaml__)
    ocaml(Ppx_deriving_yaml__Attrs)
    ocaml(Ppx_deriving_yaml__Helpers)
    ocaml(Ppx_deriving_yaml__Value)
    ocaml(Ppxlib)
    ocaml(Ppxlib__)
    ocaml(Ppxlib__Ast_builder)
    ocaml(Ppxlib__Ast_builder_generated)
    ocaml(Ppxlib__Ast_builder_intf)
    ocaml(Ppxlib__Ast_pattern)
    ocaml(Ppxlib__Ast_pattern0)
    ocaml(Ppxlib__Ast_pattern_generated)
    ocaml(Ppxlib__Ast_traverse)
    ocaml(Ppxlib__Ast_traverse0)
    ocaml(Ppxlib__Attribute)
    ocaml(Ppxlib__Code_path)
    ocaml(Ppxlib__Common)
    ocaml(Ppxlib__Deriving)
    ocaml(Ppxlib__Expansion_context)
    ocaml(Ppxlib__Import)
    ocaml(Ppxlib__Loc)
    ocaml(Ppxlib__Location)
    ocaml(Ppxlib__Longident)
    ocaml(Ppxlib__Name)
    ocaml(Ppxlib__Utils)
    ocaml(Ppxlib_ast)
    ocaml(Ppxlib_ast__)
    ocaml(Ppxlib_ast__Ast)
    ocaml(Ppxlib_ast__Ast_helper_lite)
    ocaml(Ppxlib_ast__Import)
    ocaml(Ppxlib_ast__Versions)
    ocaml(Ppxlib_traverse_builtins)
    ocaml(Primitive)
    ocaml(Profile)
    ocaml(Sexplib0)
    ocaml(Sexplib0__)
    ocaml(Sexplib0__Sexp)
    ocaml(Sexplib0__Sexp_conv)
    ocaml(Sexplib0__Sexp_conv_grammar)
    ocaml(Sexplib0__Sexp_grammar)
    ocaml(Shape)
    ocaml(Stdlib)
    ocaml(Stdlib__Arg)
    ocaml(Stdlib__Array)
    ocaml(Stdlib__Buffer)
    ocaml(Stdlib__Bytes)
    ocaml(Stdlib__BytesLabels)
    ocaml(Stdlib__Char)
    ocaml(Stdlib__Digest)
    ocaml(Stdlib__Either)
    ocaml(Stdlib__Format)
    ocaml(Stdlib__Hashtbl)
    ocaml(Stdlib__Int32)
    ocaml(Stdlib__Lazy)
    ocaml(Stdlib__Lexing)
    ocaml(Stdlib__List)
    ocaml(Stdlib__ListLabels)
    ocaml(Stdlib__Map)
    ocaml(Stdlib__Obj)
    ocaml(Stdlib__Option)
    ocaml(Stdlib__Seq)
    ocaml(Stdlib__Set)
    ocaml(Stdlib__StdLabels)
    ocaml(Stdlib__String)
    ocaml(Stdlib__StringLabels)
    ocaml(Stdlib__Uchar)
    ocaml(Stdppx)
    ocaml(Subst)
    ocaml(Type_immediacy)
    ocaml(Types)
    ocaml(Warnings)
    rtld(GNU_HASH)

ocaml-ppx-deriving-yaml-devel (rpmlib, GLIBC filtered):
    ocaml(Astlib)
    ocaml(Astlib__)
    ocaml(Astlib__Ast_402)
    ocaml(Astlib__Ast_403)
    ocaml(Astlib__Ast_404)
    ocaml(Astlib__Ast_405)
    ocaml(Astlib__Ast_406)
    ocaml(Astlib__Ast_407)
    ocaml(Astlib__Ast_408)
    ocaml(Astlib__Ast_409)
    ocaml(Astlib__Ast_410)
    ocaml(Astlib__Ast_411)
    ocaml(Astlib__Ast_412)
    ocaml(Astlib__Ast_413)
    ocaml(Astlib__Ast_414)
    ocaml(Astlib__Ast_500)
    ocaml(Astlib__Location)
    ocaml(Astlib__Longident)
    ocaml(Astlib__Parse)
    ocaml(Asttypes)
    ocaml(Build_path_prefix_map)
    ocaml(CamlinternalFormatBasics)
    ocaml(CamlinternalLazy)
    ocaml(CamlinternalOO)
    ocaml(Clflags)
    ocaml(Cmi_format)
    ocaml(Compmisc)
    ocaml(Env)
    ocaml(Ident)
    ocaml(Identifiable)
    ocaml(Load_path)
    ocaml(Location)
    ocaml(Longident)
    ocaml(Misc)
    ocaml(Ocaml_common)
    ocaml(Ocaml_shadow)
    ocaml(Outcometree)
    ocaml(Parsetree)
    ocaml(Path)
    ocaml(Ppx_deriving_yaml__)
    ocaml(Ppx_deriving_yaml__Attrs)
    ocaml(Ppx_deriving_yaml__Helpers)
    ocaml(Ppx_deriving_yaml__Value)
    ocaml(Ppxlib)
    ocaml(Ppxlib__)
    ocaml(Ppxlib__Ast_builder)
    ocaml(Ppxlib__Ast_builder_generated)
    ocaml(Ppxlib__Ast_builder_intf)
    ocaml(Ppxlib__Ast_pattern)
    ocaml(Ppxlib__Ast_pattern0)
    ocaml(Ppxlib__Ast_pattern_generated)
    ocaml(Ppxlib__Ast_traverse)
    ocaml(Ppxlib__Ast_traverse0)
    ocaml(Ppxlib__Attribute)
    ocaml(Ppxlib__Code_path)
    ocaml(Ppxlib__Common)
    ocaml(Ppxlib__Deriving)
    ocaml(Ppxlib__Expansion_context)
    ocaml(Ppxlib__Import)
    ocaml(Ppxlib__Loc)
    ocaml(Ppxlib__Location)
    ocaml(Ppxlib__Longident)
    ocaml(Ppxlib__Name)
    ocaml(Ppxlib__Utils)
    ocaml(Ppxlib_ast)
    ocaml(Ppxlib_ast__)
    ocaml(Ppxlib_ast__Ast)
    ocaml(Ppxlib_ast__Ast_helper_lite)
    ocaml(Ppxlib_ast__Import)
    ocaml(Ppxlib_ast__Versions)
    ocaml(Ppxlib_traverse_builtins)
    ocaml(Primitive)
    ocaml(Profile)
    ocaml(Sexplib0)
    ocaml(Sexplib0__)
    ocaml(Sexplib0__Sexp)
    ocaml(Sexplib0__Sexp_conv)
    ocaml(Sexplib0__Sexp_conv_grammar)
    ocaml(Sexplib0__Sexp_grammar)
    ocaml(Shape)
    ocaml(Stdlib)
    ocaml(Stdlib__Arg)
    ocaml(Stdlib__Array)
    ocaml(Stdlib__Buffer)
    ocaml(Stdlib__Bytes)
    ocaml(Stdlib__BytesLabels)
    ocaml(Stdlib__Char)
    ocaml(Stdlib__Digest)
    ocaml(Stdlib__Either)
    ocaml(Stdlib__Format)
    ocaml(Stdlib__Hashtbl)
    ocaml(Stdlib__Int32)
    ocaml(Stdlib__Lazy)
    ocaml(Stdlib__Lexing)
    ocaml(Stdlib__List)
    ocaml(Stdlib__ListLabels)
    ocaml(Stdlib__Map)
    ocaml(Stdlib__Obj)
    ocaml(Stdlib__Option)
    ocaml(Stdlib__Seq)
    ocaml(Stdlib__Set)
    ocaml(Stdlib__StdLabels)
    ocaml(Stdlib__String)
    ocaml(Stdlib__StringLabels)
    ocaml(Stdlib__Uchar)
    ocaml(Stdppx)
    ocaml(Subst)
    ocaml(Type_immediacy)
    ocaml(Types)
    ocaml(Warnings)
    ocaml-ppx-deriving-devel(x86-64)
    ocaml-ppx-deriving-yaml(x86-64)
    ocaml-ppxlib-devel(x86-64)
    ocaml-yaml-devel(x86-64)
    ocamlx(CamlinternalOO)
    ocamlx(Ppx_deriving_yaml__Attrs)
    ocamlx(Ppx_deriving_yaml__Helpers)
    ocamlx(Ppx_deriving_yaml__Value)
    ocamlx(Ppxlib)
    ocamlx(Ppxlib__Ast_builder)
    ocamlx(Ppxlib__Ast_pattern)
    ocamlx(Ppxlib__Attribute)
    ocamlx(Ppxlib__Deriving)
    ocamlx(Ppxlib__Expansion_context)
    ocamlx(Ppxlib__Location)
    ocamlx(Ppxlib_ast__Ast_helper_lite)
    ocamlx(Stdlib)
    ocamlx(Stdlib__List)
    ocamlx(Stdlib__Option)

ocaml-ppx-deriving-yaml-debuginfo (rpmlib, GLIBC filtered):

ocaml-ppx-deriving-yaml-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ocaml-ppx-deriving-yaml:
    ocaml(Ppx_deriving_yaml)
    ocaml(Ppx_deriving_yaml__)
    ocaml(Ppx_deriving_yaml__Attrs)
    ocaml(Ppx_deriving_yaml__Helpers)
    ocaml(Ppx_deriving_yaml__Value)
    ocaml-ppx-deriving-yaml
    ocaml-ppx-deriving-yaml(x86-64)

ocaml-ppx-deriving-yaml-devel:
    ocaml(Ppx_deriving_yaml)
    ocaml(Ppx_deriving_yaml__)
    ocaml(Ppx_deriving_yaml__Attrs)
    ocaml(Ppx_deriving_yaml__Helpers)
    ocaml(Ppx_deriving_yaml__Value)
    ocaml-ppx-deriving-yaml-devel
    ocaml-ppx-deriving-yaml-devel(x86-64)
    ocamlx(Ppx_deriving_yaml)
    ocamlx(Ppx_deriving_yaml__)
    ocamlx(Ppx_deriving_yaml__Attrs)
    ocamlx(Ppx_deriving_yaml__Helpers)
    ocamlx(Ppx_deriving_yaml__Value)

ocaml-ppx-deriving-yaml-debuginfo:
    debuginfo(build-id)
    ocaml-ppx-deriving-yaml-debuginfo
    ocaml-ppx-deriving-yaml-debuginfo(x86-64)

ocaml-ppx-deriving-yaml-debugsource:
    ocaml-ppx-deriving-yaml-debugsource
    ocaml-ppx-deriving-yaml-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2217730 -m fedora-38-x86_64 -L /var/tmp/repo
Buildroot used: fedora-38-x86_64
Active plugins: C/C++, Ocaml, Shell-api, Generic
Disabled plugins: Java, Python, SugarActivity, fonts, Haskell, Perl, R, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /var/tmp/repo/ocaml-uucd-debuginfo-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucd-debugsource-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucd-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucd-devel-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-globalize-debuginfo-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-globalize-debugsource-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-globalize-devel-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-globalize-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-stable-witness-debuginfo-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-stable-witness-debugsource-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-stable-witness-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-ppx-stable-witness-devel-0.16.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uunf-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uunf-debuginfo-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uunf-devel-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uunf-debugsource-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucp-debuginfo-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucp-debugsource-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucp-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-uucp-devel-15.0.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-debuginfo-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-debugsource-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-sexp-debuginfo-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-sexp-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-sexp-devel-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-3.1.0-1.fc38.x86_64.rpm
    /var/tmp/repo/ocaml-yaml-devel-3.1.0-1.fc38.x86_64.rpm

Comment 4 Richard W.M. Jones 2023-06-27 08:50:39 UTC
*** This package is APPROVED for Fedora ***

Comment 5 Jerry James 2023-06-28 23:04:52 UTC
(In reply to Richard W.M. Jones from comment #2)
> As in bug 2217729, would make sense to replace %if 0 with a named
> conditional like %if %{run_tests}.

I have made that change, at the same URLs as above.  Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2023-06-28 23:07:40 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-deriving-yaml

Comment 7 Jerry James 2023-07-13 23:04:51 UTC
The package has been built in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.