Bug 2218241 - [RHEL8]python-pip: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation)
Summary: [RHEL8]python-pip: Python tarfile extraction needs change to avoid a warning ...
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: python-pip
Version: 8.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Petr Viktorin
QA Contact: Lukáš Zachar
URL:
Whiteboard:
Depends On: CVE-2007-4559
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-28 14:13 UTC by Charalampos Stratakis
Modified: 2023-08-16 09:50 UTC (History)
4 users (show)

Fixed In Version: python-pip-9.0.3-23.el8
Doc Type: No Doc Update
Doc Text:
Clone Of: 2207997
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-161100 0 None None None 2023-06-28 14:16:27 UTC

Comment 2 Charalampos Stratakis 2023-08-10 11:25:43 UTC
In order to test it:

Run this script to create a malformed tarball:

"""
import tarfile

def mkinfo(name, **kwargs):
    tarinfo = tarfile.TarInfo(name=name)
    for name, value in kwargs.items():
        setattr(tarinfo, name, value)
    return tarinfo

with tarfile.open('evil.tar.gz', 'w:gz') as tf:
    tf.addfile(mkinfo('./pyproject.toml'))
    tf.addfile(mkinfo('./tmp', type=tarfile.SYMTYPE,
                      linkname='../../../../../../../../tmp'))
    tf.addfile(mkinfo('./tmp/poc'))
"""

Do a python3 -m pip install evil.tar.gz

It will fail with: FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-8lk56uxg-build/setup.py'

Whereas on the fixed pip it should reject the operation with:
"tarfile.OutsideDestinationError: 'tmp/poc' would be extracted to '/tmp/poc', which is outside the destination"

Comment 3 Charalampos Stratakis 2023-08-10 11:30:22 UTC
Verified on the PR.


Note You need to log in before you can comment on or make changes to this bug.