Bug 2218267 - [RHEL8]python38:3.8/python38: python38-pip: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation)
Summary: [RHEL8]python38:3.8/python38: python38-pip: Python tarfile extraction needs c...
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: python3x-pip
Version: 8.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Petr Viktorin
QA Contact: Lukáš Zachar
URL:
Whiteboard:
Depends On: CVE-2007-4559
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-28 14:25 UTC by Charalampos Stratakis
Modified: 2023-08-16 09:46 UTC (History)
4 users (show)

Fixed In Version: python38-3.8-8090020230810143931.d9f72c26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 2207997
: 2218275 (view as bug list)
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-161111 0 None None None 2023-06-28 14:28:45 UTC

Comment 2 Charalampos Stratakis 2023-08-09 23:45:54 UTC
Verified through the PR with:

"""
import tarfile

def mkinfo(name, **kwargs):
    tarinfo = tarfile.TarInfo(name=name)
    for name, value in kwargs.items():
        setattr(tarinfo, name, value)
    return tarinfo

with tarfile.open('evil.tar.gz', 'w:gz') as tf:
    tf.addfile(mkinfo('./pyproject.toml'))
    tf.addfile(mkinfo('./tmp', type=tarfile.SYMTYPE,
                      linkname='../../../../../../../../tmp'))
    tf.addfile(mkinfo('./tmp/poc'))
"""

And then run python3.9 -m pip install evil.tar.gz

On an unpatched pip the evil.tar.gz will install successfully.

On a fixed/patched one a "tarfile.OutsideDestinationError: 'tmp/poc' would be extracted to '/tmp/poc', which is outside the destination" will appear.


Note You need to log in before you can comment on or make changes to this bug.