Bug 2218309 - odf must-gather does not collect multus NetworkAttachmentDefinitions [NEEDINFO]
Summary: odf must-gather does not collect multus NetworkAttachmentDefinitions
Keywords:
Status: MODIFIED
Alias: None
Product: Red Hat OpenShift Data Foundation
Classification: Red Hat Storage
Component: must-gather
Version: 4.13
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
: ---
Assignee: yati padia
QA Contact: Oded
URL:
Whiteboard:
Depends On:
Blocks: 2232482
TreeView+ depends on / blocked
 
Reported: 2023-06-28 17:41 UTC by Blaine Gardner
Modified: 2023-08-17 05:15 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2232482 (view as bug list)
Environment:
Last Closed:
Embargoed:
muagarwa: needinfo? (oviner)
ypadia: needinfo? (oviner)
muagarwa: needinfo? (ypadia)


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github red-hat-storage ocs-operator pull 2137 0 None open Collect network-attachment-definitions for multus feature 2023-08-16 05:49:49 UTC
Github red-hat-storage odf-must-gather pull 36 0 None open Collect network-attachment-definitions for multus feature 2023-06-29 12:45:44 UTC

Description Blaine Gardner 2023-06-28 17:41:11 UTC
Description of problem (please be detailed as possible and provide log
snippests):

The ODF must-gather does not collect NetworkAttachmentDefinitions that affect Multus. The must-gather should be updated to collect NetworkAttachmentDefinition resources from the "default" and "openshift-storage" namespaces.


Version of all relevant components (if applicable):

I would hope this can be part of an upcoming 4.13.z release.


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

No.


Is there any workaround available to the best of your knowledge?

OCP must-gather collects NetworkAttachmentDefinitions


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1


Can this issue reproducible? Yes.


Can this issue reproduce from the UI? N/A


If this is a regression, please provide more details to justify this: N/A


Steps to Reproduce:
It is not necessary to install ODF with multus enabled to repro!

First, create these two NetworkAttachmentDefinitions:

  apiVersion: k8s.cni.cncf.io/v1
  kind: NetworkAttachmentDefinition
  metadata:
    name: cluster-net
    namespace: openshift-storage
  spec:
    config: '{ "cniVersion": "0.3.1", "type": "macvlan", "master": "br-ex", "mode":
      "bridge", "ipam": { "type": "whereabouts", "range": "192.168.30.0/24" } }'

  apiVersion: k8s.cni.cncf.io/v1
  kind: NetworkAttachmentDefinition
  metadata:
    name: cluster-net
  spec:
    config: '{ "cniVersion": "0.3.1", "type": "macvlan", "master": "br-ex", "mode":
      "bridge", "ipam": { "type": "whereabouts", "range": "192.168.30.0/24" } }'


Next, collect an ODF must-gather

Both NADs should be collected but are not. The first NAD is in the openshift-storage NS, and the second is in the default NS. NADs from other NSes do not need to be collected for ODF.

Comment 2 Blaine Gardner 2023-07-19 17:15:08 UTC
I see this is merged into the m-g main codebase and is in 4.14. 

@etamir would you like to target a 4.13.z backport as well? 
What about 4.12.z for any support exceptions?

Comment 6 Blaine Gardner 2023-08-15 17:42:03 UTC
@ypadia would you be able to take the action to make sure backport BZs get created for 4.13.z and 4.12.z? I'd like to get this off of my todo list to keep focusing on Rook BZs. Thanks :)

Comment 7 Mudit Agarwal 2023-08-16 04:35:55 UTC
Yati, please create clones for 4.13/4.12. Reach out to Sunil for adding the backports to the respective z-streams.

Oded, please provide qa_ack

Comment 9 Mudit Agarwal 2023-08-17 05:07:45 UTC
Yati, please create clones bugs for 4.13/4.12


Note You need to log in before you can comment on or make changes to this bug.