spec: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06125026-lomt-junction-fonts/lomt-junction-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06125026-lomt-junction-fonts/lomt-junction-fonts-0%5E20140329gitfb73260-1.fc39.src.rpm Description: Junction is a a humanist sans-serif, and the first open-source type project started by The League of Moveable Type. It has been updated (2014) to include additional weights (light/bold) and expanded international support. fas: fed500 Reproducible: Always
Hi Benson, Some things I noticed: - Use rpmautospec macros (%autorelease, %autochangelog) You're not required to use them, but it is recommended. More info: https://fedoraproject.org/wiki/Changes/rpmautospec https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default - BuildRequires: fontforge This doesn't seem to be necessary - Add the readme.markdown to documentation - fullname in incorrect format According to the packaging guidelines: "Fontconfig rules MUST rewrite fullname to <family> <style> if it has a different value" It currently looks like this: Junction Light Junction-Light Junction Regular Junction-Regular Junction Bold Junction-Bold And should look like: Junction Light Junction Light Junction Regular Junction Junction Bold Junction Bold Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* SIL Open Font License", "SIL Open Font License 1.1". 204 files have unknown license. Detailed output of licensecheck in /home/arthur/fedora-review/2218461-lomt- junction-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: lomt-junction-fonts-0^20140329gitfb73260-1.fc38.noarch.rpm lomt-junction-fonts-0^20140329gitfb73260-1.fc38.src.rpm ============================================================================================================================ rpmlint session starts =========================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmy3v3cye')] checks: 31, packages: 2 lomt-junction-fonts.noarch: W: no-documentation ============================================================================================= 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ============================================================================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 lomt-junction-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/theleagueof/junction/archive/fb73260e86dd301b383cf6cc9ca8e726ef806535/junction-fb73260.tar.gz : CHECKSUM(SHA256) this package : ae68c492db156dd0320dbbe64719585cdc028a420f8e42ac71c4352c4891e309 CHECKSUM(SHA256) upstream package : ae68c492db156dd0320dbbe64719585cdc028a420f8e42ac71c4352c4891e309 Requires -------- lomt-junction-fonts (rpmlib, GLIBC filtered): config(lomt-junction-fonts) fontpackages-filesystem Provides -------- lomt-junction-fonts: config(lomt-junction-fonts) font(junction) font(junctionbold) font(junctionlight) font(junctionregular) lomt-junction-fonts metainfo() metainfo(org.fedoraproject.lomt-junction-fonts.metainfo.xml) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2218461 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api, fonts Disabled plugins: Java, Haskell, Python, C/C++, PHP, R, Perl, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks. Prefer not to use %autorelease and %autochangelog Fontforge uses postscript names, and for the full name, these must be ascii and cannot contain spaces or characters such as []%{}(). Updated to the following: $ fc-scan Junction-light.otf Pattern has 26 elts (size 32) family: "Junction"(s) "Junction Light"(s) familylang: "en"(s) "en"(s) style: "Light"(s) "Regular"(s) stylelang: "en"(s) "en"(s) fullname: "Junction-Light"(s) fullnamelang: "en"(s) slant: 0(i)(s) weight: 50(f)(s) width: 100(f)(s) foundry: "lomt"(s) file: "Junction-light.otf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 81d0432e ff7fffff ff7fffff 0001: ff3073fc 0032f330 3f3cc198 67fcf313 00000000 00000000 00000000 30000000 0002: 00000000 00800000 00000000 00000000 00000000 00000000 3f0000c0 00000000 001e: 00000000 00000000 00000000 00000000 0000003f 00000000 00000000 000c0000 0020: 33180000 00000044 00000000 00000000 00000000 00000000 00000000 00000000 0021: 00000000 00000004 00000000 00000000 00000000 00000000 00000000 00000000 0022: 00040000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00fb: 0000001f 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|ay|bi|br|ch|co|cy|da|de|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|ia|id|ie|io|is|it|ki|lb|mg|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pt|rm|sma|smj|so|sq|ss|st|sv|sw|tl|tn|ts|uz|vo|vot|wa|xh|yap|zu|an|fil|ht|jv|kj|kwm|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za(s) fontversion: 65667(i)(s) capability: "otlayout:latn"(s) fontformat: "CFF"(s) decorative: False(s) postscriptname: "Junction"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: False(s) order: 0(i)(s) Will see if can update the full name, may need to use other software, https://github.com/fontforge/fontforge/issues/280 https://github.com/chrissimpkins/fontname.py/blob/master/fontname.py https://github.com/fonttools/fonttools/tree/main spec: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06155311-lomt-junction-fonts/lomt-junction-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06155311-lomt-junction-fonts/lomt-junction-fonts-0%5E20140329gitfb73260-1.fc39.src.rpm
Created attachment 1974902 [details] The .spec file difference from Copr build 6125104 to 6155314
Got the fields to update. Need to save as sfd first, then generate a new otf file. $ fc-scan Junction-light.otf Pattern has 26 elts (size 32) family: "Junction"(s) familylang: "en"(s) style: "Light"(s) stylelang: "en"(s) fullname: "Junction Light"(s) fullnamelang: "en"(s) slant: 0(i)(s) weight: 40(f)(s) width: 100(f)(s) foundry: "lomt"(s) file: "Junction-light.otf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 81d0432e ff7fffff ff7fffff 0001: ff3073fc 0032f330 3f3cc198 67fcf313 00000000 00000000 00000000 30000000 0002: 00000000 00800000 00000000 00000000 00000000 00000000 3f0000c0 00000000 001e: 00000000 00000000 00000000 00000000 0000003f 00000000 00000000 000c0000 0020: 33180000 00000044 00000000 00000000 00000000 00000000 00000000 00000000 0021: 00000000 00000004 00000000 00000000 00000000 00000000 00000000 00000000 0022: 00040000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00fb: 0000001f 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|ay|bi|br|ch|co|cy|da|de|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|ia|id|ie|io|is|it|ki|lb|mg|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pt|rm|sma|smj|so|sq|ss|st|sv|sw|tl|tn|ts|uz|vo|vot|wa|xh|yap|zu|an|fil|ht|jv|kj|kwm|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za(s) fontversion: 65601(i)(s) capability: "otlayout:latn"(s) fontformat: "CFF"(s) decorative: False(s) postscriptname: "Junction"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: False(s) order: 0(i)(s) $ fc-scan Junction-regular.otf Pattern has 26 elts (size 32) family: "Junction"(s) familylang: "en"(s) style: "Regular"(s) stylelang: "en"(s) fullname: "Junction"(s) fullnamelang: "en"(s) slant: 0(i)(s) weight: 80(f)(s) width: 100(f)(s) foundry: "lomt"(s) file: "Junction-regular.otf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 81d0432e ff7fffff ff7fffff 0001: ff3073fc 0032f330 3f3cc198 67fcf313 00000000 00000000 00000000 30000000 0002: 00000000 00800000 00000000 00000000 00000000 00000000 3f0000c0 00000000 001e: 00000000 00000000 00000000 00000000 0000003f 00000000 00000000 000c0000 0020: 33180000 00000044 00000000 00000000 00000000 00000000 00000000 00000000 0021: 00000000 00000004 00000000 00000000 00000000 00000000 00000000 00000000 0022: 00040000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00fb: 0000001f 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|ay|bi|br|ch|co|cy|da|de|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|ia|id|ie|io|is|it|ki|lb|mg|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pt|rm|sma|smj|so|sq|ss|st|sv|sw|tl|tn|ts|uz|vo|vot|wa|xh|yap|zu|an|fil|ht|jv|kj|kwm|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za(s) fontversion: 65601(i)(s) capability: "otlayout:latn"(s) fontformat: "CFF"(s) decorative: False(s) postscriptname: "Junction"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: False(s) order: 0(i)(s) $ fc-scan Junction-bold.otf Pattern has 26 elts (size 32) family: "Junction"(s) familylang: "en"(s) style: "Bold"(s) stylelang: "en"(s) fullname: "Junction Bold"(s) fullnamelang: "en"(s) slant: 0(i)(s) weight: 200(f)(s) width: 100(f)(s) foundry: "lomt"(s) file: "Junction-bold.otf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 81d0432e ff7fffff ff7fffff 0001: ff3073dc 0032f310 3f3cc198 67f8f313 00000000 00000000 00000000 30000000 0002: 00000000 00800000 00000000 00000000 00000000 00000000 3f0000c0 00000000 001e: 00000000 00000000 00000000 00000000 0000003f 00000000 00000000 000c0000 0020: 33180000 00000044 00000000 00000000 00000000 00000000 00000000 00000000 0021: 00000000 00000004 00000000 00000000 00000000 00000000 00000000 00000000 0022: 00040000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00fb: 0000001f 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|ay|bi|br|ch|co|cy|da|de|en|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|ia|id|ie|io|is|it|ki|lb|mg|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pt|rm|sma|smj|so|sq|ss|st|sv|sw|tl|tn|ts|uz|vo|vot|wa|xh|yap|zu|an|fil|ht|jv|kj|kwm|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za(s) fontversion: 65601(i)(s) capability: "otlayout:latn"(s) fontformat: "CFF"(s) decorative: False(s) postscriptname: "Junction"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: False(s) order: 0(i)(s) spec: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06156251-lomt-junction-fonts/lomt-junction-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/junction-fonts/fedora-rawhide-x86_64/06156251-lomt-junction-fonts/lomt-junction-fonts-0%5E20140329gitfb73260-1.fc39.src.rpm
Looks good, package APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/lomt-junction-fonts
Thanks
FEDORA-2023-482e54c40a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-482e54c40a
FEDORA-2023-fd45dec161 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fd45dec161
FEDORA-2023-fd45dec161 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fd45dec161 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fd45dec161 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-482e54c40a has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-482e54c40a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-482e54c40a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-482e54c40a has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-fd45dec161 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.