Description of problem: We created a metric name linter in kubevirt/containerized-data-importer based on promlint: https://github.com/kubevirt/containerized-data-importer/pull/2774. This metrics names failed: clone_progress: counter metrics should have "_total" or "_timestamp_seconds" suffix clone_progress: name need to start with 'kubevirt_' kubevirt_cdi_incomplete_storageprofiles_total: non-counter metrics should not have "_total" suffix kubevirt_cdi_operator_up_total: non-counter metrics should not have "_total" suffix In order to pass the linter the names can be: `clone_progress` to `kubevirt_cdi_clone_progress_percentage_total` `kubevirt_cdi_incomplete_storageprofiles_total` to `kubevirt_cdi_incomplete_storageprofiles` `kubevirt_cdi_operator_up_total` to `kubevirt_cdi_operator_up` Version-Release number of selected component (if applicable): 4.13 How reproducible: 100% Steps to Reproduce: 1. cd containerized-data-importer 2. checkout the pr https://github.com/kubevirt/containerized-data-importer/pull/2774 3. remove the ignored metrics from excludedMetrics list in tools/prom-metrics-collector/metrics_collector.go (in order to see the erros) 4.make lint-metrics or make test-lint Actual results: some metric names are not aligned with promlint linter. Expected results: Metrics named will be aligned with promlint linter and Prometheus best practices. Additional info: as for now the list of metrics are ignored in the linter.
In addition, in https://github.com/kubevirt/hostpath-provisioner-operator, kubevirt_hpp_operator_up_total metric is failing the metrics linter.
(In reply to Assaf Admi from comment #1) > In addition, in https://github.com/kubevirt/hostpath-provisioner-operator, > kubevirt_hpp_operator_up_total metric is failing the metrics linter. HPP will be handled in a separate bug: https://bugzilla.redhat.com/show_bug.cgi?id=2224828
clone_ will be fixed in: https://github.com/kubevirt/containerized-data-importer/issues/2515
(In reply to Aviv Litman from comment #3) > clone_ will be fixed in: > https://github.com/kubevirt/containerized-data-importer/issues/2515 *clone_progress