RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2218844 - [RHEL 9] rename() duplicates paths for a file on NFSv4 volume
Summary: [RHEL 9] rename() duplicates paths for a file on NFSv4 volume
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: kernel
Version: 9.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jeff Layton
QA Contact: Zhi Li
URL:
Whiteboard:
Depends On:
Blocks: 2209174
TreeView+ depends on / blocked
 
Reported: 2023-06-30 08:22 UTC by Zhi Li
Modified: 2023-11-07 11:06 UTC (History)
8 users (show)

Fixed In Version: kernel-5.14.0-362.4.1.el9_3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-07 08:49:05 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab redhat/rhel/src/kernel rhel-9 merge_requests 909 0 None None None 2023-09-18 16:42:58 UTC
Red Hat Issue Tracker RHELPLAN-161304 0 None None None 2023-06-30 08:23:29 UTC
Red Hat Product Errata RHSA-2023:6583 0 None None None 2023-11-07 08:50:10 UTC

Description Zhi Li 2023-06-30 08:22:32 UTC 
Description of problem:
-rename() duplicates paths for a file on NFSv4 volume.

Version-Release number of selected component (if applicable):
kernel-5.14.0-331.el9.x86_64

How reproducible:
always

Steps to Reproduce:
1. Mount a NFSv4 volume with noac on node1 and node2.

[root@node1 ~]# mount -o noac server:/srv/export /mnt/nfs
[root@node2 ~]# mount -o noac server:/srv/export /mnt/nfs

2. Create directories and a file.

[root@node1 ~]# mkdir /mnt/nfs/{A,B}; touch /mnt/nfs/A/f

3. Move the file from A to B on the node1.

[root@node1 ~]# mv /mnt/nfs/A/f /mnt/nfs/B/

4. cat the file on the node2, and move it from B to A.

[root@node2 ~]# cat /mnt/nfs/B/f; mv /mnt/nfs/B/f /mnt/nfs/A/

5. Move it again from A to B on the node1.

[root@node1 ~]# mv /mnt/nfs/A/f /mnt/nfs/B/

6. cat the file again on the node2, and move it from B to A again.

[root@node2 ~]# cat /mnt/nfs/B/f; mv /mnt/nfs/B/f /mnt/nfs/A/
mv: `/mnt/nfs/B/f' and `/mnt/nfs/A/f' are the same file

Actual results:
- File paths are duplicated, and mv is failed with "... are the same file".

Expected results
- No duplicate, and mv is succeeded.

Additional info:

This issue exists on rhel9.3 but does not occur on rhel8.9, please confirm if this is a valid bug for rhel9.

Beaker job:
Test passed on rhel8.9(kernel-4.18.0-498.el8):
https://beaker.engineering.redhat.com/jobs/7988933

Test failed on rhel9.3 (kernel-5.14.0-331.el9)
https://beaker.engineering.redhat.com/jobs/8017247
Comment 2 Murphy Zhou 2023-09-05 02:03:01 UTC 
Hi team,

Has anyone looked into this regression?
Comment 5 Benjamin Coddington 2023-09-08 16:47:03 UTC 
Finally bisected back to:
638e3e7d9493 nfsd: use the getattr operation to fetch i_version

Could be the assumption about change attr for directories is incorrect?  I am digging in, but maybe you see the problem right away Jeff?
Comment 6 Benjamin Coddington 2023-09-08 18:03:01 UTC 
This doesn't reproduce on:
615e95831ec3 (HEAD -> bisect) Merge tag 'v6.6-vfs.ctime' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs

Jeff suspects this is the xfs change attr issue he's already fixed upstream, and has a couple of directions to choose from for a fix here, so handing this over.

Here's my single-system reproducer (commented lines are for a non-restart bisect attempt):
#!/bin/bash

set -o xtrace
set -o errexit

umount -a -t nfs4

sudo rmmod nfsv4 nfsv3 nfs || true

#sudo systemctl stop nfs-server

#sudo umount /proc/fs/nfsd || true
#sleep 1

#sudo rmmod nfsd rpcsec_gss_krb5 auth_rpcgss lockd nfs_acl || true

#
#LOCALVERSION="" make -C /devel/linux-nfs -j10 M=fs/nfs
#LOCALVERSION="" make -C /devel/linux-nfs -j10 M=fs/nfsd
#
#sudo insmod /devel/linux-nfs/fs/nfs/nfs.ko
#sudo insmod /devel/linux-nfs/fs/nfs/nfsv4.ko

#sudo modprobe lockd
#sudo modprobe nfs_acl
#sudo modprobe auth_rpcgss
#sudo modprobe rpcsec_gss_krb5

#sudo insmod /devel/linux-nfs/fs/nfsd/nfsd.ko

sudo systemctl start nfs-server

mkdir /mnt/localhost1 || true
mkdir /mnt/localhost2 || true
mount -t nfs -ov4,sec=sys,noac,nosharecache localhost:/exports /mnt/localhost1
mount -t nfs -ov4,sec=sys,noac,nosharecache localhost:/exports /mnt/localhost2

rm -rf /exports/{A,B}

mkdir /mnt/localhost1/{A,B}

touch /mnt/localhost1/A/f
mv /mnt/localhost1/A/f /mnt/localhost1/B/
cat /mnt/localhost2/B/f
mv /mnt/localhost2/B/f /mnt/localhost2/A/
mv /mnt/localhost1/A/f /mnt/localhost1/B/

umount -a -t nfs4
Comment 7 Jeff Layton 2023-09-09 17:21:05 UTC 
This turns out to be an ancient nfsd bug, that only manifested with the changes to how we fetch and present the change attr. Patch posted here for upstream:

    https://lore.kernel.org/linux-nfs/ZPyMyv1nNFV2whKP@tissot.1015granger.net/T/#t
Comment 27 Zhi Li 2023-09-20 06:08:19 UTC 
Moving to VERIFIED according to the comment#26.
Comment 29 errata-xmlrpc 2023-11-07 08:49:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6583
Note You need to log in before you can comment on or make changes to this bug.