Bug 221921 - vgreduce gives wrong return code after successful removal of failed mirror log device
vgreduce gives wrong return code after successful removal of failed mirror lo...
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: lvm2 (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jonathan Earl Brassow
Corey Marthaler
Depends On:
  Show dependency treegraph
Reported: 2007-01-08 17:58 EST by Jonathan Earl Brassow
Modified: 2007-11-30 17:07 EST (History)
6 users (show)

See Also:
Fixed In Version: RHBA-2007-0287
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-07 20:15:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Output of vgreduce --removemissing (536.84 KB, text/plain)
2007-01-08 17:58 EST, Jonathan Earl Brassow
no flags Details
Patch that fixes problem (478 bytes, patch)
2007-01-08 18:01 EST, Jonathan Earl Brassow
no flags Details | Diff

  None (edit)
Description Jonathan Earl Brassow 2007-01-08 17:58:49 EST
$SUBJECT causes problems for dmeventd when it tries to determine whether the
command failed or succeeded.

The problem seems to be that lib/metadata/mirror.c:reconfigure_mirror_images
removes the log_lv and then tools/vgreduce.c:_make_vg_consistent tries again. 
The last one fails (because it isn't there) and terminates the command with an
error exit code.

The only ill side-effects of this is misleading (very concerning) messages in
the log:
Jan  8 14:19:46 neo-04 dmeventd[4475]: vgreduce operation failed (5).
Jan  8 14:19:46 neo-04 dmeventd[4475]: Failed to remove faulty devices in vg-lv
Comment 1 Jonathan Earl Brassow 2007-01-08 17:58:50 EST
Created attachment 145116 [details]
Output of vgreduce --removemissing
Comment 2 Jonathan Earl Brassow 2007-01-08 18:01:36 EST
Created attachment 145118 [details]
Patch that fixes problem

Patch checks for lv in vg before issuing the removal.
Comment 6 Jonathan Earl Brassow 2007-01-09 11:00:02 EST
reassigning to agk so he can look at (?include?) this short patch
Comment 7 Alasdair Kergon 2007-01-09 18:15:25 EST
added upstream for next release
Comment 9 Corey Marthaler 2007-01-24 12:07:15 EST
fix verified in lvm2-2.02.19-1.el4.

Jan 24 06:12:16 link-08 lvm[4627]: Completed: vgreduce --removemissing vg
Jan 24 06:12:16 link-08 lvm[4627]: vg-corey_mirror is now in-sync
Jan 24 06:12:18 link-08 lvm[4627]: No longer monitoring mirror device
vg-corey_mirror for events
Comment 14 Red Hat Bugzilla 2007-05-07 20:15:19 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.