Spec URL: http://tkmame.retrogames.com/fedora-extras/xwnc.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/xwnc-0.3.3-1.src.rpm Description: Mix of Xvnc and XDarwin with improved protocol.
- package meets naming guidelines - package meets packaging guidelines, including a comment specifying the fact that parallel make is broken - license ( GPL v2) OK, text in %doc, matches source - spec file legible, in am. english - source is the last available version and matches upstream, f6df982eaebd4bf7f26661c126a1747a9cb0ecb1 xwnc-0.3.3.tar.gz - package compiles on devel (x86_64) - no missing BR - MINOR: duplicate BR autoconf (by automake), automake (by libtool) - no locales - not relocatable - owns all directories/files that it creates, does not own foreign files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - is an X server, so no need for .desktop file - no .la, no scriptlets, nothing related to devel (static, header files) - rpmlint is silent on both src.rpm and generated binary rpm - does not segfault on start :) I suggest the following - modify %{_bindir}/* into %{_bindir}/Xwnc so that you have better control and do not pull in unneeded stuff in case upstream changes something - add NEWS to %doc, it seems to contain more useful info then the included README - fix BR if you feel like it (according to packaging rules, duplicate BR are acceptable) APPROVED
- Removed glob from %files - Added NEWS to %doc - Not sure about your comment on BR, so I didnt fix anything in that regard - imported new srpm into cvs - added entry to owners.list - built successfully for devel - added cvs sync request for FC5/6 - THANKS FOR THE REVIEW!
libtool pulls in automake which in turn pulls in autoconf. Therefore it is enough to BR libtool
okay, I'll fix this in the -3 release. Seems also I did not have the latest debian patch applied, I will also update this in the -3 release. Thanks again.