Bug 2219683 - Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC implementation
Summary: Review Request: rust-maybe-async - Procedural macro to unify SYNC and ASYNC i...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-04 18:53 UTC by blinxen
Modified: 2023-07-05 17:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-05 17:51:12 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2023-07-04 18:53:18 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async-0.2.7-1.fc39.src.rpm

Description:
A procedural macro to unify SYNC and ASYNC implementation.

Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-07-05 12:40:55 UTC
Not sure what's happening here:

>  ERROR: 'Error HTTP Error 403: Forbidden downloading https://blinxen.fedorapeople.org/rust-maybe-async/rust-maybe-async-0.2.7-1.fc39.src.rpm'

Comment 2 Fabio Valentini 2023-07-05 12:41:41 UTC
Side note: The correct term is "procedural macro", not "procedure macro".

Comment 3 blinxen 2023-07-05 16:01:50 UTC
For some reason the parent directory (rust-maybe-async) did not have execute permissions. Should be fine now.

> Side note: The correct term is "procedural macro", not "procedure macro".

Nice catch, will updated the summary and description.

Comment 4 Fabio Valentini 2023-07-05 16:51:12 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

It would be great if you could review one of my packages in return.

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-05 17:12:26 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-maybe-async

Comment 6 blinxen 2023-07-05 17:51:12 UTC
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e48f7130eb


Note You need to log in before you can comment on or make changes to this bug.