Bug 2221326 - Playbooks list is ignored for FFU and minor update
Summary: Playbooks list is ignored for FFU and minor update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: osp-director-operator-container
Version: 17.1 (Wallaby)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ga
: 17.1
Assignee: Ollie Walsh
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2221327
TreeView+ depends on / blocked
 
Reported: 2023-07-08 00:53 UTC by Ollie Walsh
Modified: 2023-08-16 00:20 UTC (History)
6 users (show)

Fixed In Version: osp-director-operator-container-1.3.1-10
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 2221327 (view as bug list)
Environment:
Last Closed: 2023-08-16 00:19:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openstack-k8s-operators osp-director-operator pull 872 0 None Merged FFU: Fix multiple playbook support in deploy agent 2023-07-10 07:59:52 UTC
Red Hat Issue Tracker OSP-26444 0 None None None 2023-07-08 00:56:53 UTC
Red Hat Issue Tracker OSPK8-706 0 None None None 2023-07-08 01:02:58 UTC
Red Hat Product Errata RHSA-2023:4582 0 None None None 2023-08-16 00:20:07 UTC

Description Ollie Walsh 2023-07-08 00:53:53 UTC
Tripleo/director uses different playbooks for deploy/update/FFU. For FFU it is a list of playbooks vs a single playbook for deploy & update.

The patch to support this was incomplete and fails to specify the desired playbooks for FFU.
It will also cause a regression for minor updates.
A regular deploy is not affected as it the default playbook.

Comment 5 pkomarov 2023-07-13 23:06:25 UTC
Verified , 
This patch accommodates correct OSP update playbooks when run.

- Visible from : 
  https://rhos-ci-jenkins.lab.eng.tlv2.redhat.com/view/DFG/view/ospk8s/view/downstream/job/DFG-ospk8s-osp-director-dev-tools-17.1_fencing_minor_update/36/artifact/ostest-working/logs/osp-deploy-update-online-migration.log
 that it ran the correct playbook - online data migration tasks were run instead of the default deployment tasks.

- The following check shows the osp director operator run log - executed the other update playbooks : 

[r@r my_workspace]$ curl https://rhos-ci-jenkins.lab.eng.tlv2.redhat.com/view/DFG/view/ospk8s/view/downstream/job/DFG-ospk8s-osp-director-dev-tools-17.1_fencing_minor_update/36/artifact/logs/must-gather-20230712T114552068993/quay-io-openstack-k8s-operators-must-gather-sha256-d3be6fa98d34c10ef8643b40c0ae6f084d4d0e6b328906418c406f69f20b73db/namespaces/openstack/pods/osp-director-operator-controller-manager-75c79b7698-dqllm/manager/manager/logs/current.log |grep -A 3 'openstackdeploy-resource  default'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  5 6587k    5  355k    0     0  1462k      0  0:00:04 --:--:--  0:00:04 1463k2023-07-12T08:49:40.237989411Z 2023-07-12T08:49:40.237Z   INFO    openstackdeploy-resource        default {"name": "update-ctlrs"}
2023-07-12T08:49:40.237989411Z 2023-07-12T08:49:40.237Z DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-osp-director-openstack-org-v1beta1-openstackdeploy", "code": 200, "reason": "", "UID": "afa01670-5493-4cc3-b0dc-d94a31b47cbe", "allowed": true}
2023-07-12T08:49:40.245760903Z 2023-07-12T08:49:40.244Z DEBUG   controller-runtime.webhook.webhooks     received request        {"webhook": "/validate-osp-director-openstack-org-v1beta1-openstackdeploy", "UID": "92f92a51-55df-4256-aa57-b66e20dcfcf3", "kind": "osp-director.openstack.org/v1beta1, Kind=OpenStackDeploy", "resource": {"group":"osp-director.openstack.org","version":"v1beta1","resource":"openstackdeploys"}}
2023-07-12T08:49:40.245760903Z 2023-07-12T08:49:40.244Z INFO    openstackdeploy-resource        validate create {"name": "update-ctlrs"}
--
2023-07-12T10:35:40.341181104Z 2023-07-12T10:35:40.341Z INFO    openstackdeploy-resource        default {"name": "update-compute"}
2023-07-12T10:35:40.341657451Z 2023-07-12T10:35:40.341Z DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-osp-director-openstack-org-v1beta1-openstackdeploy", "code": 200, "reason": "", "UID": "55970f7c-4b4b-42f9-b28f-659b5130afd1", "allowed": true}
2023-07-12T10:35:40.353011177Z 2023-07-12T10:35:40.351Z DEBUG   controller-runtime.webhook.webhooks     received request        {"webhook": "/validate-osp-director-openstack-org-v1beta1-openstackdeploy", "UID": "95c2632f-8ef7-4b82-807a-cfe4162d6195", "kind": "osp-director.openstack.org/v1beta1, Kind=OpenStackDeploy", "resource": {"group":"osp-director.openstack.org","version":"v1beta1","resource":"openstackdeploys"}}
2023-07-12T10:35:40.353011177Z 2023-07-12T10:35:40.352Z INFO    openstackdeploy-resource        validate create {"name": "update-compute"}
--
2023-07-12T10:52:40.399501445Z 2023-07-12T10:52:40.399Z INFO    openstackdeploy-resource        default {"name": "update-ceph"}
2023-07-12T10:52:40.399755980Z 2023-07-12T10:52:40.399Z DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-osp-director-openstack-org-v1beta1-openstackdeploy", "code": 200, "reason": "", "UID": "ff657b39-7f4f-4e00-b1bf-fe4223ad2fdb", "allowed": true}
2023-07-12T10:52:40.406351149Z 2023-07-12T10:52:40.406Z DEBUG   controller-runtime.webhook.webhooks     received request        {"webhook": "/validate-osp-director-openstack-org-v1beta1-openstackdeploy", "UID": "230e9cda-96f9-4e6e-83fc-853cfb629d01", "kind": "osp-director.openstack.org/v1beta1, Kind=OpenStackDeploy", "resource": {"group":"osp-director.openstack.org","version":"v1beta1","resource":"openstackdeploys"}}
2023-07-12T10:52:40.406445556Z 2023-07-12T10:52:40.406Z INFO    openstackdeploy-resource        validate create {"name": "update-ceph"}
--
2023-07-12T10:53:18.367862773Z 2023-07-12T10:53:18.367Z INFO    openstackdeploy-resource        default {"name": "update-online-migration"}
2023-07-12T10:53:18.368168491Z 2023-07-12T10:53:18.368Z DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-osp-director-openstack-org-v1beta1-openstackdeploy", "code": 200, "reason": "", "UID": "e62ad2b9-b47c-418d-b10c-8a77faf70861", "allowed": true}
2023-07-12T10:53:18.376729635Z 2023-07-12T10:53:18.376Z DEBUG   controller-runtime.webhook.webhooks     received request        {"webhook": "/validate-osp-director-openstack-org-v1beta1-openstackdeploy", "UID": "5e9bd3c5-0ef3-43ca-a4d8-8511a00a5a78", "kind": "osp-director.openstack.org/v1beta1, Kind=OpenStackDeploy", "resource": {"group":"osp-director.openstack.org","version":"v1beta1","resource":"openstackdeploys"}}
2023-07-12T10:53:18.376925330Z 2023-07-12T10:53:18.376Z INFO    openstackdeploy-resource        validate create {"name": "update-online-migration"}
 64 6587k   64 4255k    0     0  3419k      0  0:00:01  0:00:01 --:--:-- 3418k--
2023-07-12T10:58:31.188680228Z 2023-07-12T10:58:31.188Z INFO    openstackdeploy-resource        default {"name": "default"}
2023-07-12T10:58:31.189022671Z 2023-07-12T10:58:31.188Z DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-osp-director-openstack-org-v1beta1-openstackdeploy", "code": 200, "reason": "", "UID": "555ebb59-b36e-4e91-8146-17a0acb498e2", "allowed": true}
2023-07-12T10:58:31.198490934Z 2023-07-12T10:58:31.198Z DEBUG   controller-runtime.webhook.webhooks     received request        {"webhook": "/validate-osp-director-openstack-org-v1beta1-openstackdeploy", "UID": "e1b7bbef-3a71-46d9-9262-e2ac36bb3202", "kind": "osp-director.openstack.org/v1beta1, Kind=OpenStackDeploy", "resource": {"group":"osp-director.openstack.org","version":"v1beta1","resource":"openstackdeploys"}}
2023-07-12T10:58:31.198742692Z 2023-07-12T10:58:31.198Z INFO    openstackdeploy-resource        validate create {"name": "default"}

Comment 11 errata-xmlrpc 2023-08-16 00:19:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Release of containers for Red Hat OpenStack Platform 17.1 director Operator), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:4582


Note You need to log in before you can comment on or make changes to this bug.