Spec URL: https://pemensik.fedorapeople.org/DNS-Compliance-Testing.spec SRPM URL: https://pemensik.fedorapeople.org/DNS-Compliance-Testing-0^20230708git4aea40b-1.fc39.src.rpm Description: Provide tools to allow Registries and Registrars (amongst others) to check the DNS protocol compliance of the servers they are delegating zones to. Fedora Account System Username: pemensik
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=103081587
This package is offered also on COPR: https://copr.fedorainfracloud.org/coprs/pemensik/DNS-Compliance-Testing/
Would anyone from DNS SIG be willing to review this package?
Output from Fedora review: DNS-Compliance-Testing.src: W: strange-permission DNS-Compliance-Testing.spec 600 DNS-Compliance-Testing.x86_64: W: spurious-executable-perm /usr/share/man/man1/genreport.1.gz DNS-Compliance-Testing.src: W: invalid-license MPLv2 DNS-Compliance-Testing.x86_64: W: invalid-license MPLv2 DNS-Compliance-Testing-debuginfo.x86_64: W: invalid-license MPLv2 DNS-Compliance-Testing-debugsource.x86_64: W: invalid-license MPLv2 SPDX should be MPL-2.0 https://spdx.org/licenses/MPL-2.0.html https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
Ah, thanks! I have made this package a while ago. It was not recommended to use SPDX licence identifiers back then. Fixed also executable bit on man page. Spec URL: https://gitlab.isc.org/pemensik/DNS-Compliance-Testing/-/raw/fedora/packaging/rpm/DNS-Compliance-Testing.spec SRPM URL: https://pemensik.fedorapeople.org/srpm/DNS-Compliance-Testing-0%5e20230708git4aea40b-1.fc39.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Mozilla Public License 2.0", "FSF All Permissive License", "*No copyright* Mozilla Public License 2.0", "FSF Unlimited License (with License Retention) GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "X11 License [generated file]". 9 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/DNS-Compliance-Testing/2221356-DNS- Compliance-Testing/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: DNS-Compliance-Testing-0^20230708git4aea40b-1.fc38.x86_64.rpm DNS-Compliance-Testing-debuginfo-0^20230708git4aea40b-1.fc38.x86_64.rpm DNS-Compliance-Testing-debugsource-0^20230708git4aea40b-1.fc38.x86_64.rpm DNS-Compliance-Testing-0^20230708git4aea40b-1.fc38.src.rpm ========================================== rpmlint session starts ========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnsy9cym_')] checks: 31, packages: 4 DNS-Compliance-Testing.src: W: strange-permission DNS-Compliance-Testing.spec 600 =========== 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 3.7 s =========== Rpmlint (debuginfo) ------------------- Checking: DNS-Compliance-Testing-debuginfo-0^20230708git4aea40b-1.fc38.x86_64.rpm ========================================== rpmlint session starts ========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphdmj1lg8')] checks: 31, packages: 1 =========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.3 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.6 s Source checksums ---------------- https://gitlab.isc.org/isc-projects/DNS-Compliance-Testing/-/archive/4aea40b/DNS-Compliance-Testing-4aea40b.tar.bz2 : CHECKSUM(SHA256) this package : 3189531662915203bed16be8c82132e172303b2af17070f5b3dfe6b9b4c3e148 CHECKSUM(SHA256) upstream package : 3189531662915203bed16be8c82132e172303b2af17070f5b3dfe6b9b4c3e148 Requires -------- DNS-Compliance-Testing (rpmlib, GLIBC filtered): bind-utils libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) DNS-Compliance-Testing-debuginfo (rpmlib, GLIBC filtered): DNS-Compliance-Testing-debugsource (rpmlib, GLIBC filtered): Provides -------- DNS-Compliance-Testing: DNS-Compliance-Testing DNS-Compliance-Testing(x86-64) DNS-Compliance-Testing-debuginfo: DNS-Compliance-Testing-debuginfo DNS-Compliance-Testing-debuginfo(x86-64) debuginfo(build-id) DNS-Compliance-Testing-debugsource: DNS-Compliance-Testing-debugsource DNS-Compliance-Testing-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/benson/Projects/FedoraPackaging/reviews/DNS-Compliance-Testing/2221356-DNS-Compliance-Testing/srpm/DNS-Compliance-Testing.spec 2023-07-17 11:12:59.876263379 +0300 +++ /home/benson/Projects/FedoraPackaging/reviews/DNS-Compliance-Testing/2221356-DNS-Compliance-Testing/srpm-unpacked/DNS-Compliance-Testing.spec 2023-07-15 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + #!/usr/bin/rpmspec -q %global commit 4aea40ba0310de10560ba6deaa2d2e6eebbe8f48 @@ -82,3 +92,4 @@ %changelog -%autochangelog +* Sat Jul 15 2023 John Doe <packager> - 0^20230708git4aea40b-1 +- Uncommitted changes Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2221356 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, SugarActivity, R, Python, fonts, Ruby, Haskell, Ocaml, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Some of the macros in the configure.ac file are obsolete: configure.ac:4: warning: The macro `AC_PROG_CC_C99' is obsolete. configure.ac:4: You should run autoupdate. ./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from... configure.ac:4: the top level configure.ac:6: warning: The macro `AC_CONFIG_HEADER' is obsolete. configure.ac:6: You should run autoupdate. ./lib/autoconf/status.m4:719: AC_CONFIG_HEADER is expanded from... configure.ac:6: the top level configure.ac:19: warning: The macro `AC_TRY_COMPILE' is obsolete. configure.ac:19: You should run autoupdate. ./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from... configure.ac:19: the top level configure.ac:36: warning: The macro `AC_TRY_COMPILE' is obsolete. configure.ac:36: You should run autoupdate. ./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from... configure.ac:36: the top level configure.ac:51: warning: The macro `AC_TRY_COMPILE' is obsolete. configure.ac:51: You should run autoupdate. b) Warnings when building: genreport.c: In function 'dotest': genreport.c:1813:17: warning: 'HMAC_CTX_new' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1813 | hmctx = HMAC_CTX_new(); | ^~~~~ In file included from genreport.c:49: /usr/include/openssl/hmac.h:33:33: note: declared here 33 | OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void); | ^~~~~~~~~~~~ genreport.c:1816:17: warning: 'HMAC_Init_ex' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1816 | if (!HMAC_Init_ex(hmctx, key, sizeof(key), EVP_sha256(), NULL)) | ^~ /usr/include/openssl/hmac.h:43:27: note: declared here 43 | OSSL_DEPRECATEDIN_3_0 int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, int len, | ^~~~~~~~~~~~ genreport.c:1818:17: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1818 | if (!HMAC_Update(hmctx, item->buf, n)) | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:1824:17: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1824 | if (!HMAC_Update(hmctx, dp, cp - dp)) /* name */ | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:1833:17: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1833 | if (!HMAC_Update(hmctx, dp, cp - dp)) /* class ttl */ | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:1847:17: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1847 | if (!HMAC_Update(hmctx, dp, cp - dp)) /* alg, time, fudge*/ | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:1864:17: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1864 | if (!HMAC_Update(hmctx, dp, cp - dp)) /* error, other len */ | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:1866:17: warning: 'HMAC_Final' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1866 | if (!HMAC_Final(hmctx, item->mac, NULL)) | ^~ /usr/include/openssl/hmac.h:47:27: note: declared here 47 | OSSL_DEPRECATEDIN_3_0 int HMAC_Final(HMAC_CTX *ctx, unsigned char *md, | ^~~~~~~~~~ genreport.c:1874:17: warning: 'HMAC_CTX_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1874 | HMAC_CTX_free(hmctx); | ^~~~~~~~~~~~~ /usr/include/openssl/hmac.h:35:28: note: declared here 35 | OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx); | ^~~~~~~~~~~~~ genreport.c:1930:25: warning: 'HMAC_CTX_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 1930 | HMAC_CTX_free(hmctx); | ^~~~~~~~~~~~~ /usr/include/openssl/hmac.h:35:28: note: declared here 35 | OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx); | ^~~~~~~~~~~~~ genreport.c: In function 'check': genreport.c:1998:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 1998 | ns_makecanon(zone, summary->zone, sizeof(summary->zone)); | ^~~~~~~~~~~~ In file included from genreport.c:30: /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c:2002:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2002 | ns_makecanon(ns, summary->ns, sizeof(summary->ns)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'lookupa': genreport.c:2211:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2211 | ns_makecanon(zone, summary->zone, sizeof(summary->zone)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c:2215:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2215 | ns_makecanon(ns, summary->ns, sizeof(summary->ns)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'lookupaaaa': genreport.c:2255:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2255 | ns_makecanon(zone, summary->zone, sizeof(summary->zone)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c:2259:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2259 | ns_makecanon(ns, summary->ns, sizeof(summary->ns)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'lookupns': genreport.c:2296:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 2296 | ns_makecanon(zone, summary->zone, sizeof(summary->zone)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'process': genreport.c:2643:29: warning: 'ns_samedomain' is deprecated [-Wdeprecated-declarations] 2643 | ns_samedomain(item->summary->zone, name)) { | ^~~~~~~~~~~~~ /usr/include/arpa/nameser.h:445:17: note: declared here 445 | int ns_samedomain (const char *, const char *) __THROW | ^~~~~~~~~~~~~ genreport.c:2817:33: warning: 'HMAC_CTX_new' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2817 | hmctx = HMAC_CTX_new(); | ^~~~~ /usr/include/openssl/hmac.h:33:33: note: declared here 33 | OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void); | ^~~~~~~~~~~~ genreport.c:2821:33: warning: 'HMAC_Init_ex' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2821 | if (!HMAC_Init_ex(hmctx, key, sizeof(key), | ^~ /usr/include/openssl/hmac.h:43:27: note: declared here 43 | OSSL_DEPRECATEDIN_3_0 int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, int len, | ^~~~~~~~~~~~ genreport.c:2827:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2827 | if (!HMAC_Update(hmctx, (const void *)"\0\040", | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2830:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2830 | if (!HMAC_Update(hmctx, item->mac, | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2836:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2836 | if (!HMAC_Update(hmctx, buf, rs - buf)) | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2841:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2841 | if (!HMAC_Update(hmctx, (const void *)"", 1)) | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2846:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2846 | if (!HMAC_Update(hmctx, ct, 6)) /* class, ttl */ | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2850:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2850 | if (!HMAC_Update(hmctx, | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2857:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2857 | if (!HMAC_Update(hmctx, tp, 8)) | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2862:33: warning: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2862 | if (!HMAC_Update(hmctx, ep, eor - ep)) | ^~ /usr/include/openssl/hmac.h:45:27: note: declared here 45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data, | ^~~~~~~~~~~ genreport.c:2864:33: warning: 'HMAC_Final' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2864 | if (!HMAC_Final(hmctx, digest, NULL)) | ^~ /usr/include/openssl/hmac.h:47:27: note: declared here 47 | OSSL_DEPRECATEDIN_3_0 int HMAC_Final(HMAC_CTX *ctx, unsigned char *md, | ^~~~~~~~~~ genreport.c:2866:33: warning: 'HMAC_CTX_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2866 | HMAC_CTX_free(hmctx); | ^~~~~~~~~~~~~ /usr/include/openssl/hmac.h:35:28: note: declared here 35 | OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx); | ^~~~~~~~~~~~~ genreport.c:3113:17: warning: 'HMAC_CTX_free' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 3113 | HMAC_CTX_free(hmctx); | ^~~~~~~~~~~~~ /usr/include/openssl/hmac.h:35:28: note: declared here 35 | OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx); | ^~~~~~~~~~~~~ genreport.c: In function 'findglue': genreport.c:3354:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 3354 | ns_makecanon(ns, buf, sizeof(buf)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'saveglue': genreport.c:3375:9: warning: 'ns_makecanon' is deprecated [-Wdeprecated-declarations] 3375 | ns_makecanon(ns, buf, sizeof(buf)); | ^~~~~~~~~~~~ /usr/include/arpa/nameser.h:449:17: note: declared here 449 | int ns_makecanon (const char *, char *, size_t) __THROW | ^~~~~~~~~~~~ genreport.c: In function 'connecttoserver': genreport.c:3304:13: warning: 'ss_len' may be used uninitialized [-Wmaybe-uninitialized] 3304 | n = connect(fd, (struct sockaddr *)&item->summary->storage, ss_len); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ genreport.c:3244:19: note: 'ss_len' was declared here 3244 | socklen_t ss_len; | ^~~~~~ genreport.c: In function 'dotest': genreport.c:1697:12: warning: 'fd' may be used uninitialized [-Wmaybe-uninitialized] 1697 | if (fd == -1) { | ^ genreport.c:1673:16: note: 'fd' was declared here 1673 | int n, fd, id, tries = 0; | ^~ genreport.c:1906:21: warning: 'ss_len' may be used uninitialized [-Wmaybe-uninitialized] 1906 | n = sendto(fd, item->buf, item->buflen, 0, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1907 | (struct sockaddr *)&item->summary->storage, ss_len); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ genreport.c:1675:19: note: 'ss_len' was declared here 1675 | socklen_t ss_len; | ^~~~~~ genreport.c:1853:17: warning: 'id' may be used uninitialized [-Wmaybe-uninitialized] 1853 | memcpy(cp, item->buf, id); /* id */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ genreport.c:1673:20: note: 'id' was declared here 1673 | int n, fd, id, tries = 0; | ^~ c) Consider adding a smoke test such as: ./genreport -D
Adding at least test list is a good idea! Spec URL: https://gitlab.isc.org/pemensik/DNS-Compliance-Testing/-/raw/fedora/packaging/rpm/DNS-Compliance-Testing.spec SRPM URL: https://pemensik.fedorapeople.org/srpm/DNS-Compliance-Testing-0%5e20230708git4aea40b-1.fc39.src.rpm But fixing warnings emitted by compilation should not block review. I have pushed a) MR: https://gitlab.isc.org/isc-projects/DNS-Compliance-Testing/-/merge_requests/19 But that should be optional. Fixing b) would take more time, when there is Patch1 required to even compile on recent distribution. Yes, the source code is not in a perfect shape, but still I don't know about any other equivalent, which would be better maintained. I think having working package is better than nothing at all, even if it emits warnings during compilation. I think that should be addressed at upstream eventually. As should be a request to create proper release, so it does not need a git snapshot. Are there any other issues blocking review pass?
[fedora-review-service-build]
Seems to build on all architectures: https://copr.fedorainfracloud.org/coprs/fed500/DNS-Compliance-Testing/build/6233686/ However, the patch seems not to be applied: https://download.copr.fedorainfracloud.org/results/fed500/DNS-Compliance-Testing/fedora-38-aarch64/06233686-DNS-Compliance-Testing/builder-live.log.gz Please check upon importing.
The Pagure repository was created at https://src.fedoraproject.org/rpms/DNS-Compliance-Testing
(In reply to Benson Muite from comment #9) > Seems to build on all architectures: > https://copr.fedorainfracloud.org/coprs/fed500/DNS-Compliance-Testing/build/ > 6233686/ > However, the patch seems not to be applied: > https://download.copr.fedorainfracloud.org/results/fed500/DNS-Compliance- > Testing/fedora-38-aarch64/06233686-DNS-Compliance-Testing/builder-live.log.gz > > Please check upon importing. Oh it is applied, checked in mockbuild and also on this log. %autosetup -p1 takes care of that. Thank you for your review!
FEDORA-2023-75c7fec89f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-75c7fec89f
FEDORA-2023-5c4f58d4a0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5c4f58d4a0
FEDORA-EPEL-2023-5aa56970bb has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-5aa56970bb
FEDORA-EPEL-2023-500774619b has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-500774619b
FEDORA-2023-75c7fec89f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-75c7fec89f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-75c7fec89f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-500774619b has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-500774619b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-5aa56970bb has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-5aa56970bb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-5c4f58d4a0 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5c4f58d4a0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5c4f58d4a0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-75c7fec89f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-5c4f58d4a0 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-500774619b has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-5aa56970bb has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.