Spec URL: https://hedayat.fedorapeople.org/reviews/golang-gitlab-yawning-edwards25519-extra.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3312/103103312/golang-gitlab-yawning-edwards25519-extra-0-0.1.20221103gitdef713f.fc39.src.rpm Description: This package provides extensions to the Go standard library's Ed25519 and curve25519 implementations, primarily extracted from curve25519-voi. This package is intended for interoperability with the standard library and the edwards25519 package as much as possible. Fedora Account System Username: hedayat
> %global forgeurl https://gitlab.com/yawning/edwards25519-extra.git Can you change to the following? Otherwise fedora-review fails. %global forgeurl https://gitlab.com/yawning/edwards25519-extra
Thank you for taking the review. Sure, this is the fixed version: Spec URL: https://hedayat.fedorapeople.org/reviews/golang-gitlab-yawning-edwards25519-extra.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9307/103329307/golang-gitlab-yawning-edwards25519-extra-0-0.1.20221103gitdef713f.fc39.src.rpm Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103329306
Fedora-review crashes still, but it seems now unrelated to the package. I checked with go2rpm that the spec is autogenerated and builds fine, approving. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gitlab-yawning-edwards25519-extra
Thanks a lot for the review. :) I added go-sig access to repository, and I'll do the others too.
FEDORA-2023-be7b21d348 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-be7b21d348
FEDORA-2023-be7b21d348 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.