Bug 2221419 - Review Request: qdl - Qualcomm Download
Summary: Review Request: qdl - Qualcomm Download
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Phil Wyett
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/andersson/qdl
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-07-08 22:59 UTC by Davide Cavalca
Modified: 2026-04-10 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-04-10 00:45:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-08 22:59:28 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/qdl/qdl.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/qdl/qdl-1.0^20230411git3b22df2-1.fc39.src.rpm

Description:
This tool communicates with USB devices of id 05c6:9008 to upload a flash
loader and use this to flash images.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-08 22:59:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103107176

Comment 2 Package Review 2024-07-08 00:45:27 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Jeremy Linton 2025-04-17 17:59:38 UTC
I just saw this, are you still interested in landing it?

Comment 4 Fedora Review Service 2025-11-20 14:17:24 UTC
Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Comment 5 Fedora Review Service 2025-11-20 14:19:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9819610
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2221419-qdl/fedora-rawhide-x86_64/09819610-qdl/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Phil Wyett 2026-03-10 08:42:20 UTC
Hi,

* Fails to build.

util.c: In function ‘attr_as_unsigned’:
util.c:94:31: error: implicit declaration of function ‘strtoul’; did you mean ‘strtok’? [-Wimplicit-function-declaration]
   94 |         return (unsigned int) strtoul((char*)value, NULL, 0);
      |                               ^~~~~~~
      |                               strtok
make: *** [<builtin>: util.o] Error 1

* Latest upstream is 2.5.

Could you update the package to latest upstream and add spec and spm file here for fuller testing?

If you no longer have an appetite to have qdl in Fedora, you can close this review request.

Regards

Phil

Comment 7 Package Review 2026-04-10 00:45:43 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.