Spec URL: https://www.ellert.se/review/oidc-agent.spec SRPM URL: https://www.ellert.se/review/oidc-agent-4.5.2-1.fc39.src.rpm Description: oidc-agent is a set of tools to manage OpenID Connect tokens and make them easily usable from the command line. We followed the ssh-agent design, so users can handle OIDC tokens in a similar way as they do with ssh keys. oidc-agent is usually started in the beginning of an X-session or a login session. Through use of environment variables the agent can be located and used to handle OIDC tokens. The agent initially does not have any account configurations loaded. You can load an account configuration by using oidc-add. Multiple account configurations may be loaded in oidc-agent concurrently. oidc-add is also used to remove a loaded configuration from oidc-agent. oidc-gen is used to initially generate an account configurations file. Fedora Account System Username: ellert
Copr build: https://copr.fedorainfracloud.org/coprs/build/6161108 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2221992-oidc-agent/fedora-rawhide-x86_64/06161108-oidc-agent/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello, Please find below the output of the review. I've flagged the following two items for more attention: [?]: Package contains no static executables. [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel Other than that, everything else looks good! Cheers, Mihai Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [?]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "GNU Lesser General Public License v2.1 or later", "ISC License", "*No copyright* ISC License", "BSD 2-Clause License". 536 files have unknown license. Detailed output of licensecheck in /2221992-oidc- agent/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: oidc-agent-cli-4.5.2-1.fc38.x86_64.rpm oidc-agent-desktop-4.5.2-1.fc38.x86_64.rpm oidc-agent-libs-4.5.2-1.fc38.x86_64.rpm oidc-agent-devel-4.5.2-1.fc38.x86_64.rpm oidc-agent-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-debugsource-4.5.2-1.fc38.x86_64.rpm oidc-agent-4.5.2-1.fc38.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaxlrx_v6')] checks: 31, packages: 7 oidc-agent.spec:92: W: unversioned-explicit-provides bundled(cjson) oidc-agent.spec:93: W: unversioned-explicit-provides bundles(clibs-list) oidc-agent-devel.x86_64: W: no-documentation oidc-agent-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/oidc-gen.desktop sh ========== 7 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 1.5 s ========= Rpmlint (debuginfo) ------------------- Checking: oidc-agent-libs-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-cli-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-desktop-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-debuginfo-4.5.2-1.fc38.x86_64.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6aofd1xi')] checks: 31, packages: 4 ========== 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 oidc-agent-cli.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-gen /lib64/libmicrohttpd.so.12 oidc-agent-libs.x86_64: E: unused-direct-shlib-dependency /usr/lib64/liboidc-agent.so.4.5.2 /lib64/libclibs_list.so.0 oidc-agent-devel.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 1.7 s Source checksums ---------------- https://github.com/indigo-dc/oidc-agent/archive/refs/tags/v4.5.2/oidc-agent-4.5.2.tar.gz : CHECKSUM(SHA256) this package : cfb0e3250485682551ab86744ab8b79b5d18149c12d36c95fa3d80ab16d68e69 CHECKSUM(SHA256) upstream package : cfb0e3250485682551ab86744ab8b79b5d18149c12d36c95fa3d80ab16d68e69 Requires -------- oidc-agent-cli (rpmlib, GLIBC filtered): /usr/bin/bash config(oidc-agent-cli) libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libmicrohttpd.so.12()(64bit) liboidc-agent.so.4()(64bit) libqrencode.so.4()(64bit) libsecret-1.so.0()(64bit) libsodium.so.23()(64bit) oidc-agent-libs(x86-64) rtld(GNU_HASH) oidc-agent-desktop (rpmlib, GLIBC filtered): config(oidc-agent-desktop) libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjavascriptcoregtk-4.0.so.18()(64bit) libsodium.so.23()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwebkit2gtk-4.0.so.37()(64bit) oidc-agent-cli oidc-agent-libs(x86-64) rtld(GNU_HASH) oidc-agent-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) oidc-agent-devel (rpmlib, GLIBC filtered): liboidc-agent.so.4()(64bit) oidc-agent-libs(x86-64) oidc-agent-debuginfo (rpmlib, GLIBC filtered): oidc-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- oidc-agent-cli: config(oidc-agent-cli) oidc-agent-cli oidc-agent-cli(x86-64) oidc-agent-desktop: application() application(oidc-gen.desktop) config(oidc-agent-desktop) mimehandler(x-scheme-handler/edu.kit.data.oidc-agent) oidc-agent oidc-agent-desktop oidc-agent-desktop(x86-64) oidc-agent-libs: liboidc-agent.so.4()(64bit) liboidc-agent4 oidc-agent-libs oidc-agent-libs(x86-64) oidc-agent-devel: oidc-agent-devel oidc-agent-devel(x86-64) oidc-agent-debuginfo: oidc-agent-debuginfo oidc-agent-debuginfo(x86-64) oidc-agent-debugsource: oidc-agent-debugsource oidc-agent-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --bug 2221992 --mock-config fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, fonts, SugarActivity, Perl, Haskell, R, Python, Ocaml, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Mihai Patrascoiu from comment #2) > Hello, > > Please find below the output of the review. > I've flagged the following two items for more attention: > > [?]: Package contains no static executables. > [?]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- > agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel > > Other than that, everything else looks good! > > Cheers, > Mihai Hi The binaries are all dynamically linked. The output from "file" says "dynamically linked": $ file usr/bin/* usr/bin/oidc-add: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=0390df2ab8c30a221e644a71dd4e574c495b04b9, for GNU/Linux 3.2.0, stripped usr/bin/oidc-agent: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=78993cf04ad343fedee5403d3a625bd66afa50b2, for GNU/Linux 3.2.0, stripped usr/bin/oidc-agent-service: Bourne-Again shell script, ASCII text executable usr/bin/oidc-gen: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6ddf0886a89cac83c90484a876d2495c05a562d2, for GNU/Linux 3.2.0, stripped usr/bin/oidc-keychain: Bourne-Again shell script, ASCII text executable usr/bin/oidc-prompt: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=02d1ee78913e4cb3f15bc88cefc2d2303d8a1da3, for GNU/Linux 3.2.0, stripped usr/bin/oidc-token: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6550338386206e81538e7e1212181986ff6770cc, for GNU/Linux 3.2.0, stripped The library is in the libs subpackage. The other subpackages Have fully qualified (version-release) requires on it: $ grep -E '(%package|%{name}-libs)' oidc-agent.spec %package cli Requires: %{name}-libs%{?_isa} = %version-%{release} %package desktop Requires: %{name}-libs%{?_isa} = %version-%{release} %package libs %package devel Requires: %{name}-libs%{?_isa} = %version-%{release} Mattias
Hello, Thank you for the answers. I am happy with the review. Adding the approved flag. Cheers, Mihai
The Pagure repository was created at https://src.fedoraproject.org/rpms/oidc-agent
FEDORA-2023-128920d61a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-128920d61a
FEDORA-EPEL-2023-eab9264188 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-eab9264188
FEDORA-2023-16e498fc53 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-16e498fc53
FEDORA-EPEL-2023-889f6395b8 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-889f6395b8
FEDORA-EPEL-2023-eab9264188 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-eab9264188 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-c0481fcc19 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c0481fcc19 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-16e498fc53 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-16e498fc53 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-16e498fc53 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-128920d61a has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-128920d61a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-128920d61a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-889f6395b8 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-889f6395b8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-eab9264188 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-16e498fc53 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-128920d61a has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-c0481fcc19 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-889f6395b8 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report.