-------------------------------------------------- Description of problem: -------------------------------------------------- as a part of the new KubeVirt rate limiting testing, I tried to increase the number of virt-api pods using this which had no issues before, I suspect the new auto virt-api auto-scaler overwrites the manual patch. ================================================================================================ apiVersion: hco.kubevirt.io/v1beta1 kind: HyperConverged metadata: annotations: deployOVS: "false" hco.kubevirt.io/tuningPolicy: '{"qps":200,"burst":400}' kubevirt.kubevirt.io/jsonpatch: '[{"op": "add", "path": "/spec/customizeComponents/patches", "value": [{"resourceType": "Deployment", "resourceName": "virt-api", "type": "json", "patch": "[{\"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 6}]"}]}]' ================================================================================================= oc get deployment virt-api -o yaml readyReplicas: 2 replicas: 2 updatedReplicas: 2 ================================================================================================= oc -n openshift-cnv get kubevirt kubevirt -o yaml customizeComponents: patches: - patch: '[{"op": "replace", "path": "/spec/replicas", "value": 6}]' resourceName: virt-api resourceType: Deployment type: json ================================================================================================= Boaz Ben Shabat, 10:29 AM [root@e29-h19-740xd storms_tool]# oc get pod -n openshift-cnv|grep virt-api virt-api-8795754c5-npd5m 1/1 Running 1 30h virt-api-8795754c5-v8tn5 1/1 Running 1 30h ================================================================================================= -------------------------------------------------- Version-Release number of selected component (if applicable): -------------------------------------------------- -------------------------------------------------- How reproducible: -------------------------------------------------- every time. -------------------------------------------------- Steps to Reproduce: -------------------------------------------------- apply the following patch: oc patch hco -n openshift-cnv kubevirt-hyperconverged --type=merge -p '{"metadata":{"annotations":{"kubevirt.kubevirt.io/jsonpatch":"[{\"op\": \"add\", \"path\": \"/spec/customizeComponents/patches\", \"value\": [{\"resourceType\": \"Deployment\", \"resourceName\": \"virt-api\", \"type\": \"json\", \"patch\": \"[{\\\"op\\\": \\\"replace\\\", \\\"path\\\": \\\"/spec/replicas\\\", \\\"value\\\": 6}]\"}]}]"}}}' -------------------------------------------------- Expected results: -------------------------------------------------- the number of virt-api pods should increase to 6
Moving this Bug to the next Target Release 4.11.6 as this PR is not yet merged, https://github.com/kubevirt/kubevirt/pull/10089
It seems that the reported issue in Bugzilla is related to a development feature that was needed for version 4.13. However, the fix for this feature has already been fixed in versions 4.12 and 4.13. It seems like the back port is failing because of unrelated patch reasons of old versions and IIUC it is not needed for 4.11 This fix doesn't justify releasing new z stream i think we should close it for now.
Please feel free to reopen this issue if you find it necessary. However, based on my evaluation, as the one who initially opened the issue, it appears that the reported feature is not currently required. Therefore, I will proceed to close the issue for now.