== Comment: #0 - Jan Polensky <Jan.Polensky> - 2023-07-14 06:51:14 == ---Problem Description--- Neovim is currently build without LuaJIT on s390x. New plugin managers (lazy.nvim, packer.nvim) for Neovim as well as newer plugins (noice, flash, edgy, ...) require LuaJIT to work. An alternative is to use LuaJIT2 on s390x which is compatible (Tested and works). Contact Information = Jan Polensky/jan.polensky, Julian Ruess/julianruess ---uname output--- Linux s8360006.lnxne.boe 6.5.0-20230713.rc1.git3.8e0070f7eda4.300.fc38.s390x #1 SMP Thu Jul 13 20:17:08 CEST 2023 s390x GNU/Linux Machine Type = LPAR, z/VM, KVM ---Debugger--- A debugger is not configured ---Steps to Reproduce--- Use Plugin Managers or Plugins that require LuaJIT. Userspace tool common name: neovim The userspace tool has the following bit modes: 64 bit Userspace rpm: neovim.s390x Userspace tool obtained from project website: na *Additional Instructions for Jan Polensky/jan.polensky, Julian Ruess/julianruess: -Attach ltrace and strace of userspace application.
I believe we should focus on LuaJIT, rather then a consumer (neovim, it relies on the system luajit package). The current LuaJIT builds are aarch64 + x86 only. Do you say there is a LuaJIT fork that's actively maintained and friendly to non-x86 arches? Because it has been always the root problem ...
------- Comment From Jan.Polensky 2023-07-14 11:15 EDT------- We know that our root problem is LuaJIT atm. But as far as we know the maintainer wants to get paid to support other architectures than the default ones. LuaJIT2 (https://github.com/openresty/luajit2) has a similar maintenance but with s390x support. It is also used by OpenResty. E.g. for neovim, we only need to change the LuaJIT dependency in https://github.com/neovim/neovim/blob/master/cmake.deps/deps.txt to LuaJIT2 and it works on s390x.
As I have said, neovim is built against the distro-provided luajit library. Building against on demand downloaded libraries isn't allowed. Thus we need to fix the system luajit first. Which would be beneficial for other packages as well.
------- Comment From julianruess 2023-07-14 12:14 EDT------- Is it possible to replace the system luajit with luajit2?
(In reply to IBM Bug Proxy from comment #5) > ------- Comment From julianruess 2023-07-14 12:14 EDT------- > Is it possible to replace the system luajit with luajit2? I hope so, but will leave it on Andreas who is the maintainer.
neovim uses luajit [1] an not openresty-luajit. I do not plan to maintain openresty-luajit nor replace luajit. The luajit package had s390x support in the past, but it bit rotted as nobody cared. The patch stopped applying. I'm not a s390x developer nor really deep into luajit. I plan to stay on luajit upstream which is actively maintained for the most used platforms. The s390x patch of the luajit RPM package had IBM addresses in it, I wrote mails to those people and told them I will drop it. They never replied! The last effort was for s390x support was [2]. It is again just a single huge patch without any history. If you care about s390x support maybe IBM should start to talk to the luajit maintainer how to get s390x support in luajit. I guess s390x in luajit would need an active maintainer! How to fix it? Option a) Get s390x support upstream into luajit Option b) We could add a s390x patch to the luajit package, if someone from IBM maintains a branch and regularly rebases it on luajit v2.1 branch! As soon as it stops applying I will drop s390x support for luajit (including neovim). [1] https://github.com/LuaJIT/LuaJIT [2] https://github.com/LuaJIT/LuaJIT/pull/891
------- Comment From iii.com 2023-08-14 18:41 EDT------- I did a rebase and successfully ran a few testsuites against the resulting code. Could you please have a look? The code is here: https://github.com/LuaJIT/LuaJIT/pull/631 or https://github.com/LuaJIT/LuaJIT/commit/ad1d41ea8bd3454c066172c99e94cc6848e470ce
------- Comment From Jan.Polensky 2023-08-15 05:27 EDT------- (In reply to comment #11) Works build Beovim with LuaJIT from your branch. No errors on s390x found. I've add a comment on github too.
------- Comment From julianruess 2023-08-15 08:25 EDT------- Same for me. Works with neovim on s390x and also added a comment on GitHub.
I'm currently reworking the spec file, after the rolling release announcement [1]. Once I'm done with it, I can give it a try. I would suggest that you discuss s390x support on the luajit mailinglist [2]. I guess this way you will get an answer from Mike Pall. [1] https://www.freelists.org/post/luajit/LuaJIT-uses-rolling-releases [2] http://luajit.org/list.html
I've checked the patchset from [1], it applies cleanly and tests are passing. I'm ok with integrating it, but how can we make sure it will not bitrot? [1] https://github.com/LuaJIT/LuaJIT/pull/631
I didn't get an answer, but tried to update it today. The patch from https://github.com/LuaJIT/LuaJIT/pull/631 doesn't apply anymore.
FEDORA-2024-26d44d709a (luajit-2.1.1707061634-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-26d44d709a
FEDORA-2024-26d44d709a (luajit-2.1.1707061634-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-a0bb66699f (lua-luv-1.48.0.2-1.fc41 and neovim-0.9.5-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a0bb66699f
FEDORA-2024-a0bb66699f (lua-luv-1.48.0.2-1.fc41 and neovim-0.9.5-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
I think we should be able to setup a CI job to verify the s390x patch still applies and builds ...
FEDORA-2024-4032785c9b (luajit-2.1.1707061634-2.fc40, lua-luv-1.48.0.2-1.fc40, and 1 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4032785c9b
FEDORA-2024-4032785c9b has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4032785c9b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4032785c9b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-dfa57f0997 (luajit-2.1.1707061634-2.fc39, lua-luv-1.48.0.2-1.fc39, and 1 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-dfa57f0997
FEDORA-2024-dfa57f0997 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-dfa57f0997` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-dfa57f0997 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-dfa57f0997 (luajit-2.1.1707061634-2.fc39, lua-luv-1.48.0.2-1.fc39, and 1 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-4032785c9b (luajit-2.1.1707061634-2.fc40, lua-luv-1.48.0.2-1.fc40, and 1 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.