Spec URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice-1.29.0-1.fc39.src.rpm Description: Chalice is a framework for writing serverless apps in python. It allows you to quickly create and deploy applications that use AWS Lambda. Fedora Account System Username: dcavalca
Copr build: https://copr.fedorainfracloud.org/coprs/build/6173865 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223011-python-chalice/fedora-rawhide-x86_64/06173865-python-chalice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial pass: - could use %pyproject_buildrequires -r requirements-test.in (requirements-test.txt locks in the versions required). that way you don't have to manually specify test dependencies - patch requirements-test.in so it does not pull in python3-mock which is deprecated. And patch the callsites to do `from unittest import mock` rather than `import mock` and upstream that potentially use try / except: try: from unittest import mock except: import mock Note that somehow it doesn't pick up `python3dist(inquirer)` even though I point fedora-review to the correct local repo $ rpm -qp --provides ../../repo/python3-inquirer-3.1.3-1.fc38.noarch.rpm python-inquirer = 3.1.3-1.fc38 python3-inquirer = 3.1.3-1.fc38 python3.11-inquirer = 3.1.3-1.fc38 python3.11dist(inquirer) = 3.1.3 python3dist(inquirer) = 3.1.3
inquirer got picked up fine, I just passed the path to the local repo wrong. So yeah, using requirements-test.in works, and please also patch the mock dependency out and send a patch upstream
Spec URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice-1.29.0-1.fc39.src.rpm Changelog: - use unittest.mock and requirements-test.in
Created attachment 1980306 [details] The .spec file difference from Copr build 6173865 to 6217857
Copr build: https://copr.fedorainfracloud.org/coprs/build/6217857 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223011-python-chalice/fedora-rawhide-x86_64/06217857-python-chalice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Missing BR: No matching package to install: 'python3dist(inquirer)'
false alarm - the inquirer review is linked. just approved it
Does not build even with inquirer DEBUG util.py:446: Error: DEBUG util.py:446: Problem: nothing provides requested (python3dist(pip) < 23.2~~ with python3dist(pip) >= 9) DEBUG util.py:448: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
Spec URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice-1.30.0-1.fc40.src.rpm Changelog: - update to 1.30.0
Copr build: https://copr.fedorainfracloud.org/coprs/build/6876651 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223011-python-chalice/fedora-rawhide-x86_64/06876651-python-chalice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This builds fine locally, something seems wrong with COPR (but I can't quite pinpoint the error in either root.log or build.log). Going to run the review locally then.
LGTM, APPROVED ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License", "*No copyright* Apache License 2.0", "Apache License 2.0", "MIT License". 356 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/chalice/2223011-python- chalice/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7374 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-chalice-1.30.0-1.fc40.noarch.rpm python-chalice-1.30.0-1.fc40.src.rpm ========================================================= rpmlint session starts ======================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0ldxot3b')] checks: 31, packages: 2 python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/requirements.txt python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.gitignore python3-chalice.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/infrastructure/app.py 644 /usr/bin/env python3 python3-chalice.noarch: W: no-manual-page-for-binary chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.chalice python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice/config.json /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice/config.json:/usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice/config.json:/usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice/config.json python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.gitignore /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.gitignore python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/app.py /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/app.py python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/requirements-dev.txt /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/requirements-dev.txt ======================== 2 packages and 0 specfiles checked; 10 errors, 15 warnings, 10 badness; has taken 0.4 s ======================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/requirements.txt python3-chalice.noarch: E: zero-length /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/requirements.txt python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.gitignore python3-chalice.noarch: E: version-control-internal-file /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.gitignore python3-chalice.noarch: E: spelling-error ('serverless', '%description -l en_US serverless -> server less, server-less, nerveless') python3-chalice.noarch: W: python-missing-require click python3-chalice.noarch: W: python-missing-require botocore python3-chalice.noarch: W: python-missing-require typing-extensions python3-chalice.noarch: W: python-missing-require six python3-chalice.noarch: W: python-missing-require pip python3-chalice.noarch: W: python-missing-require jmespath python3-chalice.noarch: W: python-missing-require pyyaml python3-chalice.noarch: W: python-missing-require inquirer python3-chalice.noarch: W: python-missing-require wheel python3-chalice.noarch: W: python-missing-require setuptools python3-chalice.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/infrastructure/app.py 644 /usr/bin/env python3 python3-chalice.noarch: W: no-manual-page-for-binary chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.gitignore python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.gitignore python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.gitignore python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.gitignore python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.chalice python3-chalice.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.gitignore python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.chalice/config.json /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.chalice/config.json:/usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.chalice/config.json:/usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.chalice/config.json python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/6001-cdk-ddb/runtime/.gitignore /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/.gitignore:/usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/.gitignore python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0009-legacy/app.py /usr/lib/python3.12/site-packages/chalice/templates/0000-rest-api/app.py python3-chalice.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/chalice/templates/0007-lambda-only/requirements-dev.txt /usr/lib/python3.12/site-packages/chalice/templates/0002-s3-event-handler/requirements-dev.txt 1 packages and 0 specfiles checked; 11 errors, 30 warnings, 3 filtered, 11 badness; has taken 0.2 s Source checksums ---------------- https://github.com/aws/chalice/archive/1.30.0/chalice-1.30.0.tar.gz : CHECKSUM(SHA256) this package : 09682c05d130becda6d0cdf5092c2d21a44dd3a018424a6820bb4026716e3cc7 CHECKSUM(SHA256) upstream package : 09682c05d130becda6d0cdf5092c2d21a44dd3a018424a6820bb4026716e3cc7 Requires -------- python3-chalice (rpmlib, GLIBC filtered): (python3.12dist(botocore) < 2~~ with python3.12dist(botocore) >= 1.14) (python3.12dist(click) < 9~~ with python3.12dist(click) >= 7) (python3.12dist(jmespath) < 2~~ with python3.12dist(jmespath) >= 0.9.3) (python3.12dist(pip) < 23.4~~ with python3.12dist(pip) >= 9) (python3.12dist(pyyaml) < 7~~ with python3.12dist(pyyaml) >= 5.3.1) (python3.12dist(six) < 2~~ with python3.12dist(six) >= 1.10) (python3.12dist(typing-extensions) < 5~~ with python3.12dist(typing-extensions) >= 4) /usr/bin/python3 python(abi) python3.12dist(inquirer) python3.12dist(setuptools) python3.12dist(wheel) Provides -------- python3-chalice: python-chalice python3-chalice python3.12-chalice python3.12dist(chalice) python3dist(chalice) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2223011 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: C/C++, Ocaml, PHP, fonts, SugarActivity, Haskell, Perl, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-chalice
FEDORA-2024-4cb64209cf has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cb64209cf
FEDORA-2024-4cb64209cf has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-494a8985f9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-494a8985f9
FEDORA-2024-494a8985f9 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-494a8985f9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-494a8985f9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-86da2628f1 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-86da2628f1
FEDORA-2024-86da2628f1 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-86da2628f1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-86da2628f1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-494a8985f9 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-86da2628f1 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.