Bug 2223036 - facts being gathered unnecessarily [NEEDINFO]
Summary: facts being gathered unnecessarily
Keywords:
Status: ON_QA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: rhel-system-roles
Version: 8.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.9
Assignee: Rich Megginson
QA Contact: David Jež
Lucie Vařáková
URL:
Whiteboard: role:ALL
Depends On: 2223032
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-14 21:57 UTC by Rich Megginson
Modified: 2023-08-13 15:11 UTC (History)
6 users (show)

Fixed In Version: rhel-system-roles-1.22.0-0.16.el8
Doc Type: Bug Fix
Doc Text:
Cause: The comparison of the present facts with the required facts is being done on unsorted lists. Consequence: The comparison may fail if the only difference is the order. Facts are gathered unnecessarily. Fix: Use difference which works no matter what the order is. Ensure that the fact gathering subsets used are the absolute minimum required. Result: The role gathers only the facts it requires, and does not unnecessarily gather facts.
Clone Of: 2223032
Environment:
Last Closed:
Type: ---
Target Upstream Version:
Embargoed:
rmeggins: needinfo? (djez)
rmeggins: needinfo? (vdanek)

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-162426 0 None None None 2023-07-14 22:00:46 UTC

Description Rich Megginson 2023-07-14 21:57:58 UTC 
+++ This bug was initially created as a clone of Bug #2223032 +++

Cause: The comparison of the present facts with the required facts is
being done on unsorted lists.

Consequence: The comparison may fail if the only difference is the
order.  Facts are gathered unnecessarily.

Fix: Use `difference` which works no matter what the order is.  Ensure
that the fact gathering subsets used are the absolute minimum required.

Result: The role gathers only the facts it requires, and does
not unnecessarily gather facts.

original issue https://github.com/linux-system-roles/storage/issues/373
storage fix https://github.com/linux-system-roles/storage/pull/374
Comment 5 Rich Megginson 2023-07-19 18:25:28 UTC 
Here is the script which can check logs https://github.com/linux-system-roles/auto-maintenance/pull/286
Note You need to log in before you can comment on or make changes to this bug.