Bug 2223081 - Review Request: python-pyasyncore - Python module asyncore for Python 3.12 onwards
Summary: Review Request: python-pyasyncore - Python module asyncore for Python 3.12 o...
Keywords:
Status: CLOSED DUPLICATE of bug 2241084
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/simonrob/pyasyncore
Whiteboard:
Depends On:
Blocks: 2219556
TreeView+ depends on / blocked
 
Reported: 2023-07-15 09:47 UTC by Terje Røsten
Modified: 2023-12-17 23:05 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-17 21:19:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 6174936 to 6174982 (831 bytes, patch)
2023-07-15 10:30 UTC, Fedora Review Service
no flags Details | Diff

Description Terje Røsten 2023-07-15 09:47:02 UTC
spec: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore.spec
srpm: https://terjeros.fedorapeople.org/python-pyasyncore/python-pyasyncore-1.0.2-1.fc39.src.rpm
desc: 
This package contains the asyncore module as found in Python
versions prior to 3.12. It is provided so that existing code relying
on import asyncore is able to continue being used without significant 
refactoring.
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=103392708
user: terjeros

Comment 1 Fedora Review Service 2023-07-15 09:50:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6174936
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223081-python-pyasyncore/fedora-rawhide-x86_64/06174936-python-pyasyncore/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-07-15 10:30:58 UTC
Created attachment 1975911 [details]
The .spec file difference from Copr build 6174936 to 6174982

Comment 4 Fedora Review Service 2023-07-15 10:31:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6174982
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223081-python-pyasyncore/fedora-rawhide-x86_64/06174982-python-pyasyncore/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Pavel Raiskup 2023-08-02 06:26:00 UTC
[fedora-review-service-build]

Comment 6 Fedora Review Service 2023-08-02 06:31:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6233580
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223081-python-pyasyncore/fedora-rawhide-x86_64/06233580-python-pyasyncore/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Pavel Raiskup 2023-08-02 06:32:21 UTC
Don't you want to start with the `pyp2spec pyasyncore` template,
according to the latest Python guidelines?
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

Comment 8 Troy Curtis 2023-08-06 17:43:41 UTC
Also the license field should use the SPDX format: PSF-2.0

Comment 9 Christian Stadelmann 2023-12-17 19:59:04 UTC
The package is available now: https://packages.fedoraproject.org/pkgs/python-pyasyncore/python3-pyasyncore/

Does this mean that this bug can be closed?

Comment 10 Terje Røsten 2023-12-17 21:19:40 UTC
Closed as dup of #2241084. I guess Adam forgot to search current package reviews.

*** This bug has been marked as a duplicate of bug 2241084 ***

Comment 11 Adam Williamson 2023-12-17 23:05:13 UTC
Sorry, I thought I did but I guess not!


Note You need to log in before you can comment on or make changes to this bug.