SPEC: https://fedorapeople.org/~limb/review/frozen/frozen.spec SRPM: https://fedorapeople.org/~limb/review/frozen/frozen-1.1.1-1.fc38.src.rpm Description: Header-only library that provides 0 cost initialization for immutable containers, fixed-size containers, and various algorithms. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6179921 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223443-frozen/fedora-rawhide-x86_64/06179921-frozen/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments on first sight: Fedora review broken on copr. Release build (instead of debug) is OK because the package is header only. (Maybe include a comment in spec or so) Build fails on Fedora 37 because a constexpr is recognized as such. This may be due to the gcc version (in which case the spec should specify a minimum version), but might also be fixed by some of the upstream commits after 1.1.1, maybe this one: https://github.com/serge-sans-paille/frozen/commit/f6dbec6d03debc68d18ae3e2d32ff408c6d52468 Is include.patch submitted upstream?
I'm also wondering about noarch (does this still compile and run the tests?). What do we do for other header-only packages (guidelines don't mention them)? Should we even produce frozen (which has just doc, and which rpmlint complains about - no binaries) or just frozen-devel?
Turns out this fixes f37: https://github.com/serge-sans-paille/frozen/commit/079f73cc5c6413127d47f325cbb34a607e2cb030 includes.patch is already in master. Debug comment added. Noarch would only build and run tests on one arch per build, and I'd rather run them on all arches. There's no hard and fast rule about header-only packages and shipping only -devel. Boost ships a license/doc only boost rpm for example. SPEC: https://fedorapeople.org/~limb/review/frozen/frozen.spec SRPM: https://fedorapeople.org/~limb/review/frozen/frozen-1.1.1-2.fc38.src.rpm
Created attachment 1976362 [details] The .spec file difference from Copr build 6179921 to 6182551
Copr build: https://copr.fedorainfracloud.org/coprs/build/6182551 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223443-frozen/fedora-rawhide-x86_64/06182551-frozen/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
For header only libraries the Packaging Guidelines have a specific section: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries You can also look at mdds package for reference. In brief: we don't need the main package, only the -devel subpackage with appropriate Provides: foo-static. The -devel subpackage should be noarch, while the main package is not, to run tests on all architectures. Also, a comment in the specfile about what the two patches are about is welcome.
Done. SPEC: https://fedorapeople.org/~limb/review/frozen/frozen.spec SRPM: https://fedorapeople.org/~limb/review/frozen/frozen-1.1.1-3.fc38.src.rpm
Created attachment 1976592 [details] The .spec file difference from Copr build 6182551 to 6187409
Copr build: https://copr.fedorainfracloud.org/coprs/build/6187409 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223443-frozen/fedora-rawhide-x86_64/06187409-frozen/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Due to fedora-review still broken I've manually reviewed the package and found it good, so marking ACCEPTED. BTW you could probably exclude builds on ix86.
Thank you!
The Pagure repository was created at https://src.fedoraproject.org/rpms/frozen