Spec URL: https://download.copr.fedorainfracloud.org/results/mkoncek/moditect/fedora-rawhide-x86_64/06181281-moditect/moditect.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mkoncek/moditect/fedora-rawhide-x86_64/06181281-moditect/moditect-1.0.0-1.fc39.src.rpm Description: The ModiTect project aims at providing productivity tools for working with the Java module system ("Jigsaw"). Currently the following tasks are supported: * Generating module-info.java descriptors for given artifacts (Maven dependencies or local JAR files) * Adding module descriptors to your project's JAR as well as existing JAR files (dependencies) * Creating module runtime images Compared to authoring module descriptors by hand, using ModiTect saves you work by defining dependence clauses based on your project's dependencies, describing exported and opened packages with patterns (instead of listing all packages separately), auto-detecting service usages and more. You also can use ModiTect to add a module descriptor to your project JAR while staying on Java 8 with your own build. Fedora Account System Username: mkoncek Notes: This package allows generation of module-info.class files in some projects, there are already at least 2 Fedora packages that should use it: google-gson, new version of apache-commons-io
Copr build: https://copr.fedorainfracloud.org/coprs/build/6181354 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223561-moditect/fedora-rawhide-x86_64/06181354-moditect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
the fedora review fails with both f37 and f38 aka: 07-18 10:56 root DEBUG Running check: CheckCleanBuildroot 07-18 10:56 root DEBUG regex: rm\s+\-[rf][rf]\s+(/home/jvanek/rpmbuild/BUILDROOT/moditect-1.0.0-1.fc37.x86_64|\$RPM_BUILD_ROOT)[^/] 07-18 10:56 root DEBUG install_sec: xmvn-install -R .xmvn-reactor -n moditect -d "/home/jvanek/rpmbuild/BUILDROOT/moditect-1.0.0-1.fc37.x86_64" jdir=target/site/apidocs; [ -d .xmvn/apidocs ] && jdir=.xmvn/apidocs /usr/bin/mkdir -p /home/jvanek/rpmbuild/BUILDROOT/moditect-1.0.0-1.fc37.x86_64/usr/share/licenses if [ -d "${jdir}" ]; then install -dm755 /home/jvanek/rpmbuild/BUILDROOT/moditect-1.0.0-1.fc37.x86_64/usr/share/javadoc/moditect cp -pr "${jdir}"/* /home/jvanek/rpmbuild/BUILDROOT/moditect-1.0.0-1.fc37.x86_64/usr/share/javadoc/moditect echo '/usr/share/javadoc/moditect' >>.mfiles-javadoc fi 07-18 10:56 root DEBUG CheckCleanBuildroot completed: 0.001 seconds 07-18 10:56 root DEBUG Running check: CheckCodeAndContent 07-18 10:56 root DEBUG CheckCodeAndContent completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckConfigNoReplace 07-18 10:56 root DEBUG CheckConfigNoReplace completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckDefattr 07-18 10:56 root DEBUG CheckDefattr completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckDescMacros 07-18 10:56 root DEBUG CheckDescMacros completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckDesktopFile 07-18 10:56 root DEBUG CheckDesktopFile completed: 0.001 seconds 07-18 10:56 root DEBUG Running check: CheckDesktopFileInstall 07-18 10:56 root DEBUG CheckDesktopFileInstall completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckDevelFilesInDevel 07-18 10:56 root DEBUG CheckDevelFilesInDevel completed: 0.000 seconds 07-18 10:56 root DEBUG Running check: CheckDirectoryRequire 07-18 10:56 root DEBUG Running: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell dnf repoquery -C -l filesystem 07-18 10:56 root DEBUG Exception down the road... Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 236, in run self._do_run(outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 99, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks self.checks.run_checks(output=output, writedown=not Settings.no_report) File "/usr/lib/python3.11/site-packages/FedoraReview/checks.py", line 381, in run_checks run_check(name) File "/usr/lib/python3.11/site-packages/FedoraReview/checks.py", line 356, in run_check check.run() File "/usr/lib/python3.11/site-packages/FedoraReview/check_base.py", line 266, in run self.run_on_applicable() File "/usr/lib/python3.11/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable filesys_dirs = set(deps.list_paths("filesystem")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/FedoraReview/deps.py", line 291, in list_paths paths = check_output(cmd, universal_newlines=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.11/subprocess.py", line 466, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', 'dnf repoquery -C -l filesystem']' returned non-zero exit status 2. 07-18 10:56 root ERROR Exception down the road... (logs in /home/jvanek/.cache/fedora-review.log) 07-18 10:56 root DEBUG Report completed: 111.962 seconds
The issue seems to be in mock, not in pkg itself. Will try to elaborate/
> The issue seems to be in mock, not in pkg itself. Will try to elaborate/ What makes you think so?
> What makes you think so? The package builds fine in my local mock as well as in Copr: https://copr.fedorainfracloud.org/coprs/mkoncek/moditect/build/6181281/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file ADDITIONAL_LICENSE_INFO is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 32663 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [!]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: moditect-1.0.0-1.fc39.noarch.rpm moditect-javadoc-1.0.0-1.fc39.noarch.rpm moditect-1.0.0-1.fc39.src.rpm =========================================================================================================== rpmlint session starts =========================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprh1zsq2o')] checks: 31, packages: 3 moditect-javadoc.noarch: W: package-with-huge-docs 99% ============================================================================ 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s ============================================================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 moditect-javadoc.noarch: W: package-with-huge-docs 99% 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/moditect/moditect/archive/1.0.0.Final/moditect-1.0.0.Final.tar.gz : CHECKSUM(SHA256) this package : 2e1d6f4c0101f4c0876c112517323f2580bbf5c539f7d3ca2344fa714b82fa7e CHECKSUM(SHA256) upstream package : 2e1d6f4c0101f4c0876c112517323f2580bbf5c539f7d3ca2344fa714b82fa7e Requires -------- moditect (rpmlib, GLIBC filtered): (java-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem mvn(com.beust:jcommander) mvn(com.github.javaparser:javaparser-core) mvn(org.eclipse.aether:aether-util) mvn(org.ow2.asm:asm) moditect-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- moditect: moditect mvn(org.moditect:moditect) mvn(org.moditect:moditect-aggregator:pom:) mvn(org.moditect:moditect-maven-plugin) mvn(org.moditect:moditect-maven-plugin:pom:) mvn(org.moditect:moditect-parent:pom:) mvn(org.moditect:moditect:pom:) moditect-javadoc: moditect-javadoc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2223561 Buildroot used: fedora-rawhide-x86_64 Active plugins: Java, Shell-api, Generic Disabled plugins: Perl, Ocaml, PHP, Haskell, R, fonts, SugarActivity, C/C++, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/moditect
Package has been built in Rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2268162