RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
The kernel uses temporary values for its integrity test in FIPS mode. It is a FIPS 140-3 requirement to zeroize these after use, but they are currently not.

To fix this, replace all instances of kfree(key) in crypto/asymmetric_keys/public_key.c with kfree_sensitive(key).


Version-Release number of selected component (if applicable):
kernel-5.14.0-340.el9

How reproducible:
Manunally inspect crypto/asymmetric_keys/public_key.c

Actual results:
kfree(key) is used

Expected results:
kfree_sensitive(key) is used

Additional info:
Please also backport this change to 9.2.z. No further backport is required at this time.

Created attachment 1976367 [details]
Proposed patch

Clemens, could you please submit this patch upstream? It looks good enough as it stands.  Thanks!

It'll be a while before I can get to doing that, since I've never sent a patch upstream for the kernel, and I don't have a lot of spare cycles at the moment.

(In reply to Herbert Xu from comment #2)
> Clemens, could you please submit this patch upstream? It looks good enough as it stands.  Thanks!

I'll handle this (upstream submission and a RHEL work), thanks Clemens for the patch, thanks Herbert for a review.

Thanks Vladis.  As you noted, it seems that this patch is already queued up upstream so we simply need to wait:

https://patchwork.kernel.org/project/linux-crypto/patch/20230717125509.105015-1-mngyadam@amazon.com/

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6583